Closed Bug 1450242 Opened 2 years ago Closed 2 years ago

Remove useless constants at the top of nsBrowserContentHandler.js

Categories

(Firefox :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: florian, Assigned: florian)

Details

Attachments

(1 file)

After the automated rewrite from bug 1433175, we are left with plenty of useless nsI* constants. This is especially obvious in nsBrowserContentHandler.js
Attached patch PatchSplinter Review
Simple change done with a regexp for all the Ci. cases. Then I did by hand the Cr. cases, fixed the wrapping of a few long lines, and merged logSystemBasedSearch into its single caller, because separating that function was useless.
Attachment #8963925 - Flags: review?(standard8)
Of course I'll revert the unintended npm-shrinkwrap.json changes in the next version.
Attachment #8963925 - Flags: review?(standard8) → review+
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe0e01b08506
Remove useless constants at the top of nsBrowserContentHandler.js, r=Standard8.
https://hg.mozilla.org/mozilla-central/rev/fe0e01b08506
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.