Closed Bug 1450269 Opened 6 years ago Closed 6 years ago

Remove BroadcastChannel inner-window-destroyed observer once DisconnectFromOwner() is called consistently

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: bkelly, Assigned: bkelly)

References

Details

Attachments

(1 file, 1 obsolete file)

After bug 1450266 is fixed we can remove the BroadcastChannel observer code from inner-window-destroyed.  I also have a test that will make sure we don't regress.
Depends on: 1450266
Comment on attachment 8963953 [details] [diff] [review]
P1 Add BroadcastChannel leak test. r=baku

I moved this test into bug 1450358.
Attachment #8963953 - Attachment is obsolete: true
Andrea, this removes the "inner-window-destroyed" observer in BroadcastChannel.  Now that DisconnectFromOwner() is called from FreeInnerObjects() we no longer need this observer.
Attachment #8965042 - Flags: review?(amarchesini)
Attachment #8965042 - Flags: review?(amarchesini) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4648479b4148
Remove the BroadcastChannel inner-window-destroyed observer in favor of DisconnectFromOwner(). r=baku
https://hg.mozilla.org/mozilla-central/rev/4648479b4148
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.