Closed Bug 1450316 Opened 7 years ago Closed 7 years ago

Run test_utils_makeGUID.js sequentially, since on macOS it makes the whole test suite slower.

Categories

(Firefox :: Sync, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: tcsc, Assigned: tcsc)

Details

Attachments

(1 file)

Possibly on other operating systems too, haven't checked. Strangely, this test it takes about 60s when run as part of a full test run, and around 3s when run on it's own. Forcing this test to run sequentially saves around 30s for a full run of the test on my machine, and while this makes absolutely no sense to me, it seems like we should do it. Patch incoming since this is basically trivial.
Comment on attachment 8963992 [details] Bug 1450316 - Run sync's test_utils_makeGUID.js sequentially https://reviewboard.mozilla.org/r/232818/#review238258 Magic. *shrugs*
Attachment #8963992 - Flags: review?(kit) → review+
Pushed by tchiovoloni@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7738d74015d3 Run sync's test_utils_makeGUID.js sequentially r=kitcambridge
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: