1450359 - Inline xptiWorkingSet into XPTInterfaceInfoManager

Status: RESOLVED WONTFIX

(Core :: XPCOM, enhancement, P3)

Description

[Andrew McCreight [:mccr8]]

Once bug 1450321 is fixed, it is easy to hide the one remaining use of mWorkingSet outside of XPTInterfaceInfoManager, and then get rid of xptiWorkingSet entirely by inlining it.

Comment 1

[Andrew McCreight [:mccr8]]

It sounds like Nika's patches will statically allocate these tables or something like it, so I'll see what if anything there is left of this to land once that settles out.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1450359, part 1 - Add and use a new getter method on XPTInterfaceInfoManager.

This eliminates the only remaining use of mWorkingSet outside of
XPTInterfaceInfoManager.

Review commit: https://reviewboard.mozilla.org/r/233462/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233462/

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1450359, part 2 - Inline mWorkingSet into XPTInterfaceInfoManager.

This class is only used in one place, so having two distinct classes
serves no purpose.

Review commit: https://reviewboard.mozilla.org/r/233464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233464/

Comment 4

[Andrew McCreight [:mccr8]]

Nika's patches make this redundant.