Closed Bug 1450367 Opened 2 years ago Closed Last year

[wpt-sync] Sync PR 10258 - Add tests for Event.srcElement and Event.returnValue

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10258 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10258
Details from upstream follow.

Mike Taylor <miket@mozilla.com> wrote:
>  Add tests for Event.srcElement and Event.returnValue
>  
>  (these tests were already r+'d in https://github.com/w3c/web-platform-tests/pull/4790, but splitting them out from the `window.event` stuff so they can land independent of that.
>  
>  r? @annevk
Component: web-platform-tests → DOM
Product: Testing → Core
Ran 32 tests and 10770 subtests
OK     : 31
PASS   : 9630
FAIL   : 1139
TIMEOUT: 2

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/dom/events/Event-constructors.html
    Event constructors 2: FAIL
    Event constructors 3: FAIL
/dom/events/Event-initEvent.html
    Properties of initEvent(type, false, false): FAIL
    Properties of initEvent(type, false, true): FAIL
    Properties of initEvent(type, true, false): FAIL
    Properties of initEvent(type, true, true): FAIL

New tests that have failures or other problems:
/dom/events/AddEventListenerOptions-passive.html
    returnValue should be ignored if-and-only-if the passive option is true: FAIL
/dom/events/Event-defaultPrevented-after-dispatch.html
    Default prevention via returnValue: FAIL
/dom/events/Event-returnValue.html
    When an event is created, returnValue should be initialized to true.: FAIL
    initEvent should unset returnValue.: FAIL
    preventDefault() should change returnValue if cancelable is true.: FAIL
    preventDefault() should not change returnValue if cancelable is false.: FAIL
    returnValue=false should have no effect if cancelable is false.: FAIL
    returnValue=true should have no effect once the canceled flag was set.: FAIL
/dom/events/EventTarget-dispatchEvent-returnvalue.html
    Return value of EventTarget.dispatchEvent() affected by preventDefault().: FAIL
    Return value of EventTarget.dispatchEvent() affected by returnValue.: FAIL
/dom/interfaces.html
    Event interface: attribute returnValue: FAIL
    Event interface: document.createEvent("Event") must inherit property "returnValue" with the proper type: FAIL
    Event interface: new CustomEvent("foo") must inherit property "returnValue" with the proper type: FAIL
    Event interface: new Event("foo") must inherit property "returnValue" with the proper type: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e683788df735
[wpt PR 10258] - Add tests for Event.srcElement and Event.returnValue, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c39066c31f9
[wpt PR 10258] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/e683788df735
https://hg.mozilla.org/mozilla-central/rev/5c39066c31f9
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.