1450416 - setTimeout/setInterval should silently fail if the worker is shutting down

Status: RESOLVED FIXED

(Core :: DOM: Workers, enhancement)

Description

[Andrea Marchesini [:baku]]

We currently say it, but we don't and we throw an exception:
https://searchfox.org/mozilla-central/source/dom/workers/WorkerPrivate.cpp#4578-4583

Comment 1

[Andrea Marchesini [:baku]]

Attachment: timeout.patch

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8964095 [details] [diff] [review]
timeout.patch

Review of attachment 8964095 [details] [diff] [review]:
-----------------------------------------------------------------

Restating:
- The tests under testing/web-platform/tests/workers/interfaces/WorkerUtils/WindowTimers/ use a weird idiom where the HTML file is also interepreted as the JS worker script, which is terrifying.
- Test test passes if setInterval() on an already self.close()d worker doesn't throw and skip the postMessage call.
- These changes are consistent with the spec at https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html#timer-initialisation-steps (and slightly above), which don't call for throwing if the global is shutting down.
- It makes sense that shutdown of a worker wants to quietly shutdown, rather than causing a sudden massive deviation from the steady-state behavior.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b537ebde3ae1
setTimeout/setInterval should silently fail if the worker is shutting down, r=asuth

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b537ebde3ae1

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10308 for changes under testing/web-platform/tests