Closed Bug 1450422 Opened 6 years ago Closed 6 years ago

Get rid of nsIDOMDataChannel

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

      No description provided.
MozReview-Commit-ID: Dei5EEd0FZO
Attachment #8964098 - Flags: review?(nika)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8964098 [details] [diff] [review]
Get rid of nsIDOMDataChannel

Review of attachment 8964098 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/reflect/xptinfo/ShimInterfaceInfo.cpp
@@ -154,5 @@
>    DEFINE_SHIM_WITH_CUSTOM_INTERFACE(nsIDOMParser, DOMParser),
>    DEFINE_SHIM(Range),
> -#ifdef MOZ_WEBRTC
> -  DEFINE_SHIM_WITH_CUSTOM_INTERFACE(nsIDOMDataChannel, RTCDataChannel),
> -#endif

I love the killing of ComponentsInterfaceShimEntries which we've got going on here :-).

These have been a huge pain for some of the XPT changes I've been working on...
Attachment #8964098 - Flags: review?(nika) → review+
https://hg.mozilla.org/mozilla-central/rev/9daca50568c8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: