1450467 - Remove the about:config overlay

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Richard Marti (:Paenglab)]

We still have a overlay to add the ability to close the about:config (Options > Advanced > General > "Condig Editor") window with ESC. See:

overlay chrome://global/content/config.xul chrome://messenger/content/configEditorOverlay.xul

Either we find a solution to hooking this directly through some JS magic or we need to consider to remove this functionality.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: configEditorOverlay.patch

Remove the about:config overlay. The window can also be closed with ALT+F4 or the close button.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8970837 [details] [diff] [review]
configEditorOverlay.patch

Thanks, looks good, I didn't test it.

Comment 3

[:aceman]

So why don't we use the window listening helper for addons from bug 1450288 to overlay this window, as I proposed?
As this is a window in TB, it could work. And we would have an internal testbed for this feature.

Comment 4

[Richard Marti (:Paenglab)]

Aceman, could you try it?

Comment 5

[Jorg K (CEST = GMT+2)]

Please don't, it's not worth it. The panel has a close button and you can close via the [x]. Please let's not waste time on this, we have more pressing issues. I'm landing this tonight.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3c40e65f0bf3
Remove the about:config overlay. r=jorgk