1450563 - Modernize browser_bug432599.js

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P3)

Description

[Marco Bonardo [:mak]]

This test uses old sync APIs and could use async/await

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1450563 - Modernize browser_bug432599.js.

Review commit: https://reviewboard.mozilla.org/r/232924/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232924/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8964177 [details]
Bug 1450563 - Modernize browser_bug432599.js.

https://reviewboard.mozilla.org/r/232924/#review238802

Looks good. r=Standard8

::: browser/base/content/test/general/browser_bug432599.js:45
(Diff revision 1)
> -  gBrowser.selectedTab = BrowserTestUtils.addTab(gBrowser);
> -  BrowserTestUtils.browserLoaded(gBrowser.selectedBrowser).then(() => {
> -    waitForStarChange(false, initTest);
>    });
>  
> -  gBrowser.loadURI(testURL);
> +  // Wait for Star button change.

Is this actually a change, or is this just ensuring the start state?

Comment 3

[Marco Bonardo [:mak]]

(In reply to Mark Banner (:standard8) from comment #2)
> Comment on attachment 8964177 [details]
> Bug 1450563 - Modernize browser_bug432599.js.
> 
> https://reviewboard.mozilla.org/r/232924/#review238802
> 
> Looks good. r=Standard8
> 
> ::: browser/base/content/test/general/browser_bug432599.js:45
> (Diff revision 1)
> > -  gBrowser.selectedTab = BrowserTestUtils.addTab(gBrowser);
> > -  BrowserTestUtils.browserLoaded(gBrowser.selectedBrowser).then(() => {
> > -    waitForStarChange(false, initTest);
> >    });
> >  
> > -  gBrowser.loadURI(testURL);
> > +  // Wait for Star button change.
> 
> Is this actually a change, or is this just ensuring the start state?

which one is a change?
The test was adding a tab, loading the page and then waiting for the star to not be pending before calling initTest.
I'm doing the same exact things afaict, just in a readable way.
I admit the comment is not great, I'll update it.

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8964177 [details]
Bug 1450563 - Modernize browser_bug432599.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232924/diff/1-2/

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 8964177 [details]
Bug 1450563 - Modernize browser_bug432599.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232924/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65bbe1ed20ee
Modernize browser_bug432599.js. r=standard8

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/65bbe1ed20ee