1450572 - Optimize windows.get

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement)

Description

[Oriol Brufau [:Oriol]]

browser.windows.get(windowId) is slow if there are lots of windows:

    for (let window of this.browserWindows(true)) {
      if (this.getId(window) === id) {
        return window;
      }
    }

https://searchfox.org/mozilla-central/rev/0e8eb01368600eb552dd558c83c64a3b6a0b89b8/toolkit/components/extensions/parent/ext-tabs-base.js#1392-1396

This should be optimized. This will also benefit browser.tabs.query({windowId}) via bug 1445316.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1450572 - Optimize windows.get(windowId)

Review commit: https://reviewboard.mozilla.org/r/232932/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232932/

Comment 2

[Oriol Brufau [:Oriol]]

Comment on attachment 8964184 [details]
Bug 1450572 - Optimize windows.get(windowId)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232932/diff/1-2/

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8964184 [details]
Bug 1450572 - Optimize windows.get(windowId)

https://reviewboard.mozilla.org/r/232932/#review238882

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57d58de5d58d
Optimize windows.get(windowId) r=mixedpuppy

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/57d58de5d58d

Comment 6

[CosminB]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!

Comment 7

[Oriol Brufau [:Oriol]]

No difference in behavior, it's just that now the code does not iterate all windows in order to find the desired one. It's observable via performance.now() with lots of windows, but manual testing doesn't seem necessary.