Closed
Bug 1450587
Opened 6 years ago
Closed 6 years ago
Update developer edition promo icon
Categories
(DevTools :: General, enhancement)
DevTools
General
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: ntim, Assigned: manishkk)
Details
Attachments
(3 files, 1 obsolete file)
Screenshot
The Developer Edition promo icon is the old pre-Quantum developer edition icon.
|
Assignee | |
Comment 1•6 years ago
|
||
which file needs to be replaced and from where?
Flags: needinfo?(ntim.bugs)
|
Reporter | |
Comment 2•6 years ago
|
||
devtools/client/framework/dev-edition-promo/dev-edition-logo.png needs to be replaced. The replacement would be: https://dxr.mozilla.org/mozilla-central/raw/browser/branding/aurora/default128.png
Flags: needinfo?(ntim.bugs)
|
|
Assignee | |
Comment 3•6 years ago
|
||
So I should replace path of 'dev-edition-logo.png' icon with 'default128.png' in these files? https://searchfox.org/mozilla-central/search?q=dev-edition-logo.png&case=true®exp=false&path=
Flags: needinfo?(ntim.bugs)
|
|
Reporter | |
Comment 4•6 years ago
|
||
No, you should keep the two files, but 'dev-edition-logo.png' needs to be updated to use the new logo.
Flags: needinfo?(ntim.bugs)
|
|
Assignee | |
Comment 5•6 years ago
|
||
So I can move 'default128.png' here in 'devtools/client/framework/dev-edition-promo' and rename them?
Flags: needinfo?(ntim.bugs)
|
|
Reporter | |
Comment 6•6 years ago
|
||
(In reply to Manish Kumar from comment #5) > So I can move 'default128.png' here in > 'devtools/client/framework/dev-edition-promo' > and rename them? You should basically copy 'default128.png' in 'devtools/client/framework/dev-edition-promo', delete 'dev-edition-logo.png', and rename 'default128.png' to 'dev-edition-logo.png'.
Flags: needinfo?(ntim.bugs)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → 1991manish.kumar
|
|
Assignee | |
Comment 7•6 years ago
|
||
Please review. Thanks
Attachment #8964270 -
Flags: review?(pbrosset)
Attachment #8964270 -
Flags: review?(ntim.bugs)
|
|
Reporter | |
Comment 8•6 years ago
|
||
Comment on attachment 8964270 [details] [diff] [review] Patch_Bug1450587 Review of attachment 8964270 [details] [diff] [review]: ----------------------------------------------------------------- Please restore browser/branding/aurora/default128.png, this file shouldn't have been deleted.
Attachment #8964270 -
Flags: review?(pbrosset)
Attachment #8964270 -
Flags: review?(ntim.bugs)
Attachment #8964270 -
Flags: review-
|
|
Assignee | |
Comment 9•6 years ago
|
||
Please review.
Attachment #8964270 -
Attachment is obsolete: true
Attachment #8964304 -
Flags: review?(ntim.bugs)
|
|
Reporter | |
Comment 10•6 years ago
|
||
|
|
Reporter | |
Comment 11•6 years ago
|
||
Comment on attachment 8964304 [details] [diff] [review] Patch_Bug1450587 Review of attachment 8964304 [details] [diff] [review]: ----------------------------------------------------------------- Works great, thanks!
Attachment #8964304 -
Flags: review?(ntim.bugs) → review+
|
||
Comment 12•6 years ago
|
||
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ba9c3035768b Update developer edition promo icon. r=ntim
|
|
||
Comment 13•6 years ago
|
||
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/57bf90c8f7b2 Followup: update allowed-dupes.mn entry. r=me
|
|
||
Comment 14•6 years ago
|
||
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5c643acb8260 Followup: fix allowed-dupes.mn entries on a CLOSED TREE. r=me
|
||
Comment 15•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ba9c3035768b https://hg.mozilla.org/mozilla-central/rev/57bf90c8f7b2 https://hg.mozilla.org/mozilla-central/rev/5c643acb8260
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•