145061 - errno == ESRCH test in nsProfileLock::Lock for XP_UNIX is backward!

Status: VERIFIED FIXED

(Core Graveyard :: Profile: BackEnd, defect)

Description

[Brendan Eich [:brendan]]

Patch coming up fast.

/be

Comment 1

[Brendan Eich [:brendan]]

This is a fix to the big profile locking patch that ccarlen landed on the trunk
for bug 76431.

/be

Comment 2

[Brendan Eich [:brendan]]

dbaron has tested the forthcoming patch, vouches for it.

/be

Comment 3

[Brendan Eich [:brendan]]

Attachment: proposed fix

Please r= and sr=, you cc'ers.

/be

Comment 4

[Conrad Carlen (not reading bugmail)]

Comment on attachment 83921 [details] [diff] [review]
proposed fix

r=ccarlen

Thanks to google:
http://list-archive.xemacs.org/xemacs-patches/200102/msg00034.html

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 83921 [details] [diff] [review]
proposed fix

I agree with the review, r=[e-mail].  Still need sr= (brendan?)

Comment 6

[Christopher Blizzard (:blizzard)]

Comment on attachment 83921 [details] [diff] [review]
proposed fix

sr=blizzard

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Patch checked in for brendan to trunk.
Needs testing (kill -9 is a good way to leave a hanging lock on a profile), then
approval with 76431.

Comment 8

[K'Trina Medina]

Verified code fix