1450627 - 14.13% Strings Strings PerfStripCharsWhitespace (osx-10-10) regression on push 17e7971cb125 (Thu Mar 29 2018)

Status: RESOLVED INVALID

(Core :: Security: PSM, defect)

Description

[Ionuț Goldan [:igoldan]]

We have detected a platform microbenchmarks regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9125b9cf1730aac801ab8a6811557e10eec7bea1&tochange=17e7971cb125034bb7b603804113cedfdb6db0ab

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

 14%  Strings PerfStripCharsWhitespace osx-10-10 opt      302,918.17 -> 345,722.92


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=12422

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Platform_Microbenchmarks

Comment 1

[Ionuț Goldan [:igoldan]]

:fkiefer Bug 1448787 seems to have caused a perf regression, according to the test above. Can you please look over this issue and state whether it is valid or not?

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

This is probably just the other side of bug 1444440 comment 7.

Comment 3

[Franziskus Kiefer [:franziskus]]

> This is probably just the other side of bug 1444440 comment 7.

Yep.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Sounds like this is somewhere between expected and invalid. Either way, doesn't seem worth pursuing any further.