1450693 - Fix migration for containers-window-update in containers.ftl

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: Fluent Migration, enhancement)

Description

[Francesco Lodolo [:flod]]

Just noticed that we messed up a migration for containers-window-update

en-US has

containers-window-update =
    .title = { $name } Container Preferences
    .style = width: 45em

Localizations will get

containers-window-update =
    .title = XXXX
    .style = 45em

Because the migration is not concatenating 'width: ' like it happens for containers-window-new.

The fix to the migration recipe is trivial, I'm still pondering on how to fix this across all locales.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Ugh, that's from before I started comparing migrations to en-US :( sorry for that!

Maybe we could introduce a new message and migrate it correctly?

Comment 2

[Francesco Lodolo [:flod]]

I think we can do it by removing the message (including comments), and re-running the migration.

Approach works with Italian, need to check with a few more locales
https://hg.mozilla.org/l10n-central/it/rev/0669d690b9ab13033b0ff489673cc491b8c0ddbe

Comment 3

[Francesco Lodolo [:flod]]

Attachment: Bug 1450693 - Fix migration for containers-window-update in containers.ftl

Review commit: https://reviewboard.mozilla.org/r/233038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233038/

Comment 4

[Francesco Lodolo [:flod]]

All locales should be fixed
https://transvision.mozfr.org/string/?entity=browser/browser/preferences/containers.ftl:containers-window-update.style&repo=gecko_strings

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8964317 [details]
Bug 1450693 - Fix migration for containers-window-update in containers.ftl

https://reviewboard.mozilla.org/r/233038/#review238496

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7bea25aeb53f
Fix migration for containers-window-update in containers.ftl r=gandalf

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7bea25aeb53f