Fix migration for containers-window-update in containers.ftl

RESOLVED FIXED

Status

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: flod, Assigned: flod)

Tracking

Details

Attachments

(1 attachment)

Just noticed that we messed up a migration for containers-window-update

en-US has

containers-window-update =
    .title = { $name } Container Preferences
    .style = width: 45em

Localizations will get

containers-window-update =
    .title = XXXX
    .style = 45em

Because the migration is not concatenating 'width: ' like it happens for containers-window-new.

The fix to the migration recipe is trivial, I'm still pondering on how to fix this across all locales.
Ugh, that's from before I started comparing migrations to en-US :( sorry for that!

Maybe we could introduce a new message and migrate it correctly?
I think we can do it by removing the message (including comments), and re-running the migration.

Approach works with Italian, need to check with a few more locales
https://hg.mozilla.org/l10n-central/it/rev/0669d690b9ab13033b0ff489673cc491b8c0ddbe
Comment on attachment 8964317 [details]
Bug 1450693 - Fix migration for containers-window-update in containers.ftl

https://reviewboard.mozilla.org/r/233038/#review238496
Attachment #8964317 - Flags: review?(gandalf) → review+
Pushed by francesco.lodolo@mozillaitalia.org:
https://hg.mozilla.org/integration/autoland/rev/7bea25aeb53f
Fix migration for containers-window-update in containers.ftl r=gandalf
https://hg.mozilla.org/mozilla-central/rev/7bea25aeb53f
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.