Closed
Bug 1450789
Opened 7 years ago
Closed 7 years ago
Fix event telemetry counters for structure conflicts
Categories
(Firefox :: Sync, enhancement, P1)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: lina, Assigned: lina)
Details
Attachments
(1 file)
* https://searchfox.org/mozilla-central/rev/f5fb323246bf22a3a3b4185882a1c5d8a2c02996/toolkit/components/places/SyncedBookmarksMirror.jsm#4180 should be `remoteItemDel`: the item was deleted *remotely*, changed *locally*, and we're taking the local change. * https://searchfox.org/mozilla-central/rev/f5fb323246bf22a3a3b4185882a1c5d8a2c02996/toolkit/components/places/SyncedBookmarksMirror.jsm#4111 should be `localItemDel`, since the item was deleted locally. Thinking more about this, `remoteItemDel` and `localItemDel` aren't very good names, because the fact that the item was deleted on one side isn't really interesting; what's more interesting is seeing which side we *take* (or what we resurrect and what we delete).
| Comment hidden (mozreview-request) |
|
||
Updated•7 years ago
|
Assignee: nobody → kit
Priority: -- → P1
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8964411 [details] Bug 1450789 - Use more accurate names for structure conflict event telemetry keys. https://reviewboard.mozilla.org/r/233138/#review238606 Looks good!
Attachment #8964411 -
Flags: review?(tchiovoloni) → review+
Pushed by kcambridge@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/720ffa73f567 Use more accurate names for structure conflict event telemetry keys. r=tcsc
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/720ffa73f567
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in
before you can comment on or make changes to this bug.
Description
•