Closed Bug 1450839 Opened 2 years ago Closed 2 years ago

Update webgl-conf/checkout in 61

Categories

(Core :: Canvas: WebGL, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

(Whiteboard: gfx-noted)

Attachments

(7 files)

We update this periodically, and it's been a while, so let's rev it.
Comment on attachment 8964454 [details]
Bug 1450839 - Exclude mochitest-errata.ini from test-disable.yml. CLOSED TREE

https://reviewboard.mozilla.org/r/233188/#review238830

A few concerns

::: dom/canvas/test/webgl-conf/generate-wrappers-and-manifest.py:181
(Diff revision 1)
>  
>  
>  def OutputFilledTemplate(templateShell, templateDict, outFilePath):
>      spanStrList = templateShell.Fill(templateDict)
>  
> -    with open(outFilePath, 'wb') as f:
> +    with open(outFilePath, 'w', newline='\n') as f:

will this be compatible with different endline standards on different OSes?

::: dom/canvas/test/webgl-conf/import.py:30
(Diff revision 1)
> +    return subprocess.run(args, check=True, shell=True, **kwargs)
> +
> +
> +src_dir = Path(REPO_DIR, 'sdk/tests').as_posix()
> +dest_dir = Path(DIR_IN_GECKO, 'checkout').as_posix()
> +run_checked("rm -rf '{}'".format(dest_dir))

I hope dest_dir will never be "$HOME" by mistake!
Attachment #8964454 - Flags: review?(kvark) → review-
Comment on attachment 8964455 [details]
Bug 1450839 - Skip deqp test files for now. -

https://reviewboard.mozilla.org/r/233190/#review238832

one question

::: dom/canvas/test/webgl-conf/generate-wrappers-and-manifest.py:384
(Diff revision 1)
>          wrapperManifestPathStr = ManifestPathStr(wrapperPathStr)
>          sectionName = '[' + wrapperManifestPathStr + ']'
>          manifestTestLineList.append(sectionName)
>  
> +        def always_skip():
> +            if '/test_deqp__' in wrapperPathStr:

Need a bit of context here. Why are we skipping deqp tests?
Attachment #8964455 - Flags: review?(kvark) → review-
Comment on attachment 8964454 [details]
Bug 1450839 - Exclude mochitest-errata.ini from test-disable.yml. CLOSED TREE

https://reviewboard.mozilla.org/r/233188/#review238830

> will this be compatible with different endline standards on different OSes?

Yes, we always want to write as \n.

> I hope dest_dir will never be "$HOME" by mistake!

I added asserts, but that path is a composite anyway.
Comment on attachment 8964455 [details]
Bug 1450839 - Skip deqp test files for now. -

https://reviewboard.mozilla.org/r/233190/#review239042

::: dom/canvas/test/webgl-conf/generate-wrappers-and-manifest.py:384
(Diff revision 1)
>          wrapperManifestPathStr = ManifestPathStr(wrapperPathStr)
>          sectionName = '[' + wrapperManifestPathStr + ']'
>          manifestTestLineList.append(sectionName)
>  
> +        def always_skip():
> +            if '/test_deqp__' in wrapperPathStr:

Added:
# Skip deqp tests for now because they take too long.
Comment on attachment 8964455 [details]
Bug 1450839 - Skip deqp test files for now. -

https://reviewboard.mozilla.org/r/233190/#review239044
Attachment #8964455 - Flags: review?(jgilbert)
Attachment #8964455 - Flags: review?(kvark)
Attachment #8964455 - Flags: review?(jgilbert)
Attachment #8964455 - Flags: review-
Attachment #8964454 - Flags: review- → review?(kvark)
Comment on attachment 8964455 [details]
Bug 1450839 - Skip deqp test files for now. -

https://reviewboard.mozilla.org/r/233190/#review239196
Attachment #8964455 - Flags: review?(kvark) → review+
Comment on attachment 8964454 [details]
Bug 1450839 - Exclude mochitest-errata.ini from test-disable.yml. CLOSED TREE

https://reviewboard.mozilla.org/r/233188/#review239202

thanks!
Attachment #8964454 - Flags: review?(kvark) → review+
Comment on attachment 8966420 [details]
Bug 1450839 - Centralize record_cherry_picks for reuse. -

https://reviewboard.mozilla.org/r/235078/#review240982

not seeing anything wrong with this patch
Attachment #8966420 - Flags: review?(kvark) → review+
Comment on attachment 8966422 [details]
Bug 1450839 - Allow running generate-wrappers from any cwd. -

https://reviewboard.mozilla.org/r/235082/#review240984
Attachment #8966422 - Flags: review?(kvark) → review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/29419d3ec291
Add webgl-conf/import.py for importing from KhronosGroup/WebGL. - r=kvark
https://hg.mozilla.org/integration/mozilla-inbound/rev/40c9812744cf
Skip deqp test files for now. - r=kvark
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc8720e23aaf
Update webgl-conf/checkout.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8f1cc8465bb
Centralize record_cherry_picks for reuse. - r=kvark
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ebe2410e617
Update with cherry-pick to fix timeouts in rgb10_a2 tests.
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac281f70ecf2
Allow running generate-wrappers from any cwd. - r=kvark
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a7d5640c5c4
Update expected failures.
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7d4984f3f66
Exclude mochitest-errata.ini from test-disable.yml. CLOSED TREE
Attachment #8964455 - Attachment is obsolete: true
Attachment #8964456 - Attachment is obsolete: true
Attachment #8966420 - Attachment is obsolete: true
Attachment #8966421 - Attachment is obsolete: true
Attachment #8966422 - Attachment is obsolete: true
Attachment #8966423 - Attachment is obsolete: true
Attachment #8964455 - Attachment is obsolete: false
Attachment #8964456 - Attachment is obsolete: false
Attachment #8966420 - Attachment is obsolete: false
Attachment #8966421 - Attachment is obsolete: false
Attachment #8966422 - Attachment is obsolete: false
Attachment #8966423 - Attachment is obsolete: false
You need to log in before you can comment on or make changes to this bug.