Closed Bug 1450861 Opened 3 years ago Closed 2 years ago

Replace `PlacesSyncUtils.getAnno` with `PlacesUtils.promiseAnnotationsForItem`

Categories

(Toolkit :: Places, enhancement, P3)

enhancement

Tracking

()

RESOLVED WONTFIX

People

(Reporter: lina, Unassigned)

References

Details

`getAnno`'s callers will probably go away with bug 1449730, but, in the meantime, we can replace our hand-rolled `getAnno` wrapper with `promiseAnnotationsForItem`. As Mark pointed out on IRC, it might be less efficient, but doesn't really matter in practice, and we'd avoid duplicating the SQL.
Priority: -- → P3
It might be interesting to replace promiseAnnotationsForItem's itemId parameter with the guid. This would allow us to drop the promiseItemId we have in a few tests at least. Unfortunately the existing code items wouldn't currently benefit from it, but it at least heads in the right direction.

That's if we keep annotations...
the plan is to remove annotations
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.