1450886 - manual "Check for Updates" for a single extension should give feedback if no update is available, when automatic update checks is disabled

Status: RESOLVED DUPLICATE of bug 1175917

(Thunderbird :: Add-Ons: General, defect)

Description

When viewing an extension in the Add-ons Manager, there is an "Automatic Updates" radio button.  When this is set to "Off", a "Check for Updates" link is visible.  Following this link has no apparent effect.

Steps to reproduce:

1. Tools->Add-ons->Extensions
2. >>> Ensure "Automatic Updates" is set to disabled <<< in settings
3. Follow the "More" link next to one extension
4. Follow the "Check for Updates" link

Expected behaviour:

5. If an update is available, I expect a dialog that informs me of this and proceeds with installation (or prompts me to ask if I want it installed).  If no update is available, I expect a dialog that informs me of this.

Observed behaviour:

5. Nothing happens.

Comment 1

[Wayne Mery (:wsmwk)]

Tristan, can you reproduce this to day with 52?  And with beta? https://www.thunderbird.net/en-US/channel/

Comment 2

[Tristan Miller]

At least for the case that no update is available, I'm still getting no feedback after following the "Check for Updates" link with Thunderbird 52.9.1 (openSUSE Tumbleweed packages).  The official beta (60.0b10) has the same problem.

Comment 3

[Andrei Hajdukewycz [:sancus]]

I can't reproduce this issue on Windows, in TB60.0b10. I tried downloading Cardbook 30.3 (https://addons.thunderbird.net/en-US/thunderbird/addon/cardbook/versions/?page=1#version-30.3), turning off automatic updates, and then hit Check for Updates, and it immediately offered me the update to 30.4.

Not sure what's going on but it may be Linux or distro-specific. What add-on are you trying to get to update?

Comment 4

[Tristan Miller]

(In reply to Tristan Miller from comment #2)
> At least for the case that no update is available, I'm still getting no
> feedback after following the "Check for Updates" link with Thunderbird
> 52.9.1 (openSUSE Tumbleweed packages).  The official beta (60.0b10) has the
> same problem.

OK, I have now tested 60.0b10 with the case that an update is indeed available.  In this case, following the "Check of Updates" link causes an "Available Updates" entry to appear in the left pane.  This is a bit inconspicuous but I suppose acceptable.

There still needs to be some feedback for the case where no update is available.

Comment 5

[Tristan Miller]

(In reply to Andrei Hajdukewycz [:sancus] from comment #3)
> I can't reproduce this issue on Windows, in TB60.0b10. I tried downloading
> Cardbook 30.3
> (https://addons.thunderbird.net/en-US/thunderbird/addon/cardbook/versions/
> ?page=1#version-30.3), turning off automatic updates, and then hit Check for
> Updates, and it immediately offered me the update to 30.4.

And what happens when no update is available? Do you get any feedback at all?

> Not sure what's going on but it may be Linux or distro-specific. What add-on
> are you trying to get to update?

I've tried with CardBook, Enigmail, Lightning, TbSync, and Exchange Calendar.  None of them give any feedback when no update is available.

For my initial report, I believe I also tried to update Enigmail or Lightning and didn't get any obvious feedback even when an update was available.  However, that was with Thunderbird 52.  (I suppose it's possible that I overlooked that an "Available Updates" entry appeared in the left pane.)

Comment 6

[Andrei Hajdukewycz [:sancus]]

I don't believe there is supposed to be any feedback if no update is available(at least, I can't recall ever seeing any in Thunderbird in the past). I agree that's a bit weird, but it's minor, and should be its own bug. We could just change the title of this bug for that.

Updates *should* work in TB52, but even if there is some issue the answer would be to upgrade to TB60, which is now out.

Comment 7

[Tristan Miller]

(In reply to Andrei Hajdukewycz [:sancus] from comment #6)
> Updates *should* work in TB52, but even if there is some issue the answer
> would be to upgrade to TB60, which is now out.

OK, I tested with 52.9.1.  If I install an old version of CardBook, I get the same "Available Updates" entry in the left pane when following the "Check for Updates" link.  As I mentioned before, it's possibly I simply overlooked this before, since it's pretty inconspicuous -- I was expecting a notice to appear near where I clicked, or else a modal dialog. I was not expecting some menu entry to appear in a place far away from where I clicked.

> I don't believe there is supposed to be any feedback if no update is
> available(at least, I can't recall ever seeing any in Thunderbird in the
> past). I agree that's a bit weird, but it's minor, and should be its own
> bug. We could just change the title of this bug for that.

OK, I'll update the bug title accordingly.

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Is this the same in Firefox? If so, then I'd suggest filing a bug there instead, or moving this bug into Toolkit :: Add-ons Manager.

Comment 9

[Tristan Miller]

Yes, it's the same in Firefox 60.1.0esr.  No feedback is given when trying to update an add-on with no available update.

Comment 10

[Tristan Miller]

Also reproducible in SeaMonkey 2.49.4.

Comment 11

[Andrew Swan [:aswan]]

In Firefox 63, I see a "No updates found" message to the left of the gear icon when no updates are found.

Comment 12

[Tristan Miller]

Does this mean the problem will not be reproducible in future versions of Thunderbird and SeaMonkey?  Or should I change the product of this bug back to Thunderbird and open a separate one for SeaMonkey?

Comment 13

[Tristan Miller]

It's been almost two years since this bug was marked as resolved, but the problem is still reproducible for me in both Thunderbird 68.8.1 and SeaMonkey 2.53.2. Andrew, could you please respond to my question in Comment #12 about whether this is just a question of waiting for the fix to make it into a stable release for these two products?

Comment 14

[Andrei Hajdukewycz [:sancus]]

I'm on TB68.9.0 and I see the message mentioned in comment #11.

https://i.imgur.com/RYwo7mC.png

Comment 15

[Tristan Miller]

(In reply to Andrei Hajdukewycz [:sancus] from comment #14)

I'm on TB68.9.0 and I see the message mentioned in comment #11.

https://i.imgur.com/RYwo7mC.png

So do I, but that's not how you reproduce this bug. What do you see when you follow the instructions given in my original report?

Comment 16

[Andrei Hajdukewycz [:sancus]]

(In reply to Tristan Miller from comment #15)

So do I, but that's not how you reproduce this bug. What do you see when you follow the instructions given in my original report?

Ah, I see, you're talking specifically about the "Check for Updates" link that appears when you turn automatic updates off for an individual add-on. This does perform an update check, but it triggers no message unlike the gear icon.

https://i.imgur.com/kUbolDt.png

However, I note this is the same behaviour as Firefox. You ONLY get the "No updates found" message if you use the gear icon to check for updates.

So this bug probably needs to be re-filed as a Toolkit-> Add-ons Manager bug to see any movement on it. I suspect aswan had this same confusion two years ago.

Comment 17

[Tristan Miller]

(In reply to Andrei Hajdukewycz [:sancus] from comment #16)

So this bug probably needs to be re-filed as a Toolkit-> Add-ons Manager bug to see any movement on it. I suspect aswan had this same confusion two years ago.

That's how I originally filed the bug. For reasons unbeknownst to me, someone refiled it as Thunderbird → Add-Ons: General two years ago. Should I refile it now and reset the resolution field?

Comment 18

[Wayne Mery (:wsmwk)]

I've reordered the steps in comment 0 to be more accurate.
This is a duplicate of bug 1175917