Closed Bug 1450924 Opened 2 years ago Closed 6 months ago

Remove use of innerHTML in reader mode's Narrate code entirely

Categories

(Toolkit :: Reader Mode, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox61 --- wontfix
firefox68 --- fixed

People

(Reporter: Gijs, Assigned: MonikaMaheshwari)

References

Details

(Whiteboard: [reader-mode-firefox-integration])

Attachments

(1 file)

bug 1447384 replaces use of a not-entirely-fixed string (locale stuff) with a fixed string. But as Johann notes:

(In reply to Johann Hofmann [:johannh] from bug 1447384 comment #5)
> We should probably file a follow-up bug for removing innerHTML entirely
> there :)
Priority: -- → P3
Whiteboard: [reader-mode-firefox-integration]

Hey, wanted to work on this issue.

(In reply to Monika Maheshwari [:MonikaMaheshwari] from comment #1)

Hey, wanted to work on this issue.

Sure. The goal will be to convert this markup:

https://searchfox.org/mozilla-central/rev/b3ac60ff061c7891e77c26b73b61804aa1a8f682/toolkit/components/narrate/NarrateControls.jsm#37-60

into using DOM creation methods (document.createElement, setAttribute, etc.) instead. Does that help get you started?

Assignee: nobody → monikamaheshwari1996

Cool. Will look into it.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/608174be279d
Remove use of innerHTML in reader mode's Narrate code entirely r=Gijs
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
https://hg.mozilla.org/projects/ash/rev/608174be279d62ecfa7e2bb81305946d50993e85
Bug 1450924 Remove use of innerHTML in reader mode's Narrate code entirely r=Gijs
You need to log in before you can comment on or make changes to this bug.