1450953 - Convert WindowActor to protocol.js

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P2)

Description

[Yulia Startsev [:yulia] OOO until July 2026]

With the update of RootActor to protocol.js we should also update WindowActor

It is instantiated via RootActor.getWindow()

Comment 1

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1450953 - Convert WindowActor to protocol.js;

Review commit: https://reviewboard.mozilla.org/r/241994/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241994/

Comment 2

[Yulia Startsev [:yulia] OOO until July 2026]

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1029b4815a033064c4627cce6dbd9de42f850d9

Comment 3

[Code Review Bot [:reviewbot]]

Comment on attachment 8973630 [details]
Bug 1450953 - Convert WindowActor to protocol.js;

https://reviewboard.mozilla.org/r/241994/#review247848


Code analysis found 4 defects in this patch:
 - 4 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/server/actors/window.js:26
(Diff revision 1)
>   * Most of the implementation is inherited from TabActor.  WindowActor exposes all tab
>   * actors via its form() request, like TabActor.
>   *
>   * You can request a specific window's actor via RootActor.getWindow().
>   *
> + * Caveat: Protocol.js expects only the prototype object, and does not maintain the prototype

Error: Line 26 exceeds the maximum line length of 90. [eslint: max-len]

::: devtools/server/actors/window.js:35
(Diff revision 1)
>   * @param connection DebuggerServerConnection
>   *        The connection to the client.
>   * @param window DOMWindow
>   *        The window.
>   */
> -function WindowActor(connection, window) {
> +

Error: More than 1 blank line not allowed. [eslint: no-multiple-empty-lines]

::: devtools/server/actors/window.js:49
(Diff revision 1)
>                         .getInterface(Ci.nsIDocShell);
>    Object.defineProperty(this, "docShell", {
>      value: docShell,
>      configurable: true
>    });
>  }

Error: Missing semicolon. [eslint: semi]

::: devtools/server/actors/window.js:50
(Diff revision 1)
>    Object.defineProperty(this, "docShell", {
>      value: docShell,
>      configurable: true
>    });
>  }
>  

Error: More than 1 blank line not allowed. [eslint: no-multiple-empty-lines]

Comment 4

[Yulia Startsev [:yulia] OOO until July 2026]

ops, didn't catch the linter issues for some reason in my editor, will fix

Comment 5

[Yulia Startsev [:yulia] OOO until July 2026]

Comment on attachment 8973630 [details]
Bug 1450953 - Convert WindowActor to protocol.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/241994/diff/1-2/

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 8973630 [details]
Bug 1450953 - Convert WindowActor to protocol.js;

https://reviewboard.mozilla.org/r/241994/#review247860

Thanks, it looks good.

::: devtools/server/actors/window.js:94
(Diff revision 2)
>    TabActor.prototype._detach.call(this);
>  
>    return true;
>  };
>  
> -exports.WindowActor = WindowActor;
> +windowPrototype.typeName = "Window";

I have the same comment than bug 1450946, this should be removed.

Comment 7

[Yulia Startsev [:yulia] OOO until July 2026]

Comment on attachment 8973630 [details]
Bug 1450953 - Convert WindowActor to protocol.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/241994/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16ac0e4e2483
Convert WindowActor to protocol.js; r=ochameau

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/16ac0e4e2483