1450969 - fix paths for MINIDUMP_STACKWALK for Windows build tasks

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Nathan Froyd [:froydnj]]

If you happen to be unfortunate enough to be testing changes that crash
xpcshell during the xpcshell self-tests, you'll be presented with error
messages like:

PROCESS-CRASH | test_child_assertions.js | application crashed [unknown top frame]
Crash dump filename: c:\users\task_1522676338\appdata\local\temp\xpc-other-mtot6h\cfaea928-e995-4430-baf9-0066c6b91be9.dmp
MINIDUMP_STACKWALK binary not found: z:\build\build\tools\breakpad\win64\minidump_stackwalk.exe

and then be told that, essentially, "your test failed because it
failed", which is unhelpful for figuring out what went wrong.

Apparently we had MINIDUMP_STACKWALK set at one point, and then it got
moved.  Let's fix this situation by a) downloading minidump_stackwalk
out of tooltool (our test harnesses do this already); and b) pointing
MINIDUMP_STACKWALK at the correct location.  With these changes, we can
once again get crash stacks if xpcshell (and probably a few other
things) fail their self tests.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: fix paths for MINIDUMP_STACKWALK for Windows build tasks

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8964548 [details] [diff] [review]
fix paths for MINIDUMP_STACKWALK for Windows build tasks

Review of attachment 8964548 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me assuming you've verified that this is actually producing useful stacks now. Thanks for fixing this longstanding annoyance!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a51cb0bc55c3
fix paths for MINIDUMP_STACKWALK for Windows build tasks; r=RyanVM

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a51cb0bc55c3