Make “Manage containers” title case

VERIFIED FIXED in Firefox 65

Status

()

VERIFIED FIXED
a year ago
3 months ago

People

(Reporter: rfeeley, Assigned: shivi)

Tracking

55 Branch
Firefox 65
Points:
---

Firefox Tracking Flags

(firefox65 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Comment 1

5 months ago
Posted patch bug-1450973.patch (obsolete) — Splinter Review
Please take a look. Thanks!
Attachment #9023882 - Flags: review?(jkt)
Comment on attachment 9023882 [details] [diff] [review]
bug-1450973.patch

Hey Shivangi, Could you amend the commit description to be specific it's just changing a containers translation.

Perhaps:
"Bug 1450973 - Update the containers about page text to use a camel case title."

Other than that this is correct, congrats on figuring out mercurial :). If you could submit a new patch with the changes description I will approve, you could just use a text editor to change the patch file or use "hg commit --amend".
Attachment #9023882 - Flags: review?(jkt) → review-
Assignee: nobody → shivangikakkar15
(Assignee)

Comment 3

5 months ago
Changes requested are done. Please review again. Thanks!
Attachment #9023890 - Flags: review?(jkt)
Comment on attachment 9023882 [details] [diff] [review]
bug-1450973.patch

Marking old patch as obsolete.
Attachment #9023882 - Attachment is obsolete: true
Comment on attachment 9023890 [details] [diff] [review]
Review changes

r+ thanks.

I don't think you will have the permission to add "checkin-needed" yet so I will add it: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree
Attachment #9023890 - Flags: review?(jkt) → review+
Keywords: checkin-needed
(Assignee)

Comment 6

5 months ago
Comment on attachment 9023882 [details] [diff] [review]
bug-1450973.patch

Marking old patch as obsolete.
(Assignee)

Comment 7

5 months ago
(In reply to Jonathan Kingston [:jkt] from comment #5)
> Comment on attachment 9023890 [details] [diff] [review]
> Review changes
> 
> r+ thanks.
> 
> I don't think you will have the permission to add "checkin-needed" yet so I
> will add it:
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Yes, Thanks!

Comment 8

5 months ago
Pushed by dvarga@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b9beb3080d1
Update the containers about page text to use a camel case title. r=jkt
Keywords: checkin-needed

Comment 9

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0b9beb3080d1
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65

Comment 10

3 months ago
I have reproduced this bug with Nightly 61.0a1 (2018-04-03) on Windows 10, 64 Bit ! 

This bug's fix is Verified with latest Beta !

Build   ID    20181220174318
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

[testday-20181221]
I have reproduced this bug with Nightly 61.0a1 (2018-04-03) on Ubuntu 18.04.1 LTS 64 Bit!
This bug's fix is now verified with latest Beta!

Build ID     20181220174318
User Agent   Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0
QA Whiteboard: [bugday-20181219]

Comment 12

3 months ago
As par comment 10 and comment 11, I am marking this bug as verified fixed.
Status: RESOLVED → VERIFIED
status-firefox65: fixed → verified
You need to log in before you can comment on or make changes to this bug.