1450973 - Make “Manage containers” title case

Status: VERIFIED FIXED

(Firefox :: Security, enhancement)

Description

[Ryan Feeley [:rfeeley]]

CURRENT:
Manage containers

PROPOSED:
Manage Containers

STRING:
https://hg.mozilla.org/l10n/gecko-strings/file/default/browser/chrome/browser/browser.properties#l911

GUIDELINES:
https://design.firefox.com/photon/copy/capitalization.html

Comment 1

[Shivangi Kakkar [:shivi]]

Attachment: bug-1450973.patch

Please take a look. Thanks!

Comment 2

[Jonathan Kingston [:jkt] he/him]

Comment on attachment 9023882 [details] [diff] [review]
bug-1450973.patch

Hey Shivangi, Could you amend the commit description to be specific it's just changing a containers translation.

Perhaps:
"Bug 1450973 - Update the containers about page text to use a camel case title."

Other than that this is correct, congrats on figuring out mercurial :). If you could submit a new patch with the changes description I will approve, you could just use a text editor to change the patch file or use "hg commit --amend".

Comment 3

[Shivangi Kakkar [:shivi]]

Attachment: Review changes

Changes requested are done. Please review again. Thanks!

Comment 4

[Jonathan Kingston [:jkt] he/him]

Comment on attachment 9023882 [details] [diff] [review]
bug-1450973.patch

Marking old patch as obsolete.

Comment 5

[Jonathan Kingston [:jkt] he/him]

Comment on attachment 9023890 [details] [diff] [review]
Review changes

r+ thanks.

I don't think you will have the permission to add "checkin-needed" yet so I will add it: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Comment 6

[Shivangi Kakkar [:shivi]]

Comment on attachment 9023882 [details] [diff] [review]
bug-1450973.patch

Marking old patch as obsolete.

Comment 7

[Shivangi Kakkar [:shivi]]

(In reply to Jonathan Kingston [:jkt] from comment #5)
> Comment on attachment 9023890 [details] [diff] [review]
> Review changes
> 
> r+ thanks.
> 
> I don't think you will have the permission to add "checkin-needed" yet so I
> will add it:
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Yes, Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b9beb3080d1
Update the containers about page text to use a camel case title. r=jkt

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/0b9beb3080d1

Comment 10

[Sajedul Islam]

I have reproduced this bug with Nightly 61.0a1 (2018-04-03) on Windows 10, 64 Bit ! 

This bug's fix is Verified with latest Beta !

Build   ID    20181220174318
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

[testday-20181221]

Comment 11

[Md Maruf Rahman]

I have reproduced this bug with Nightly 61.0a1 (2018-04-03) on Ubuntu 18.04.1 LTS 64 Bit!
This bug's fix is now verified with latest Beta!

Build ID     20181220174318
User Agent   Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0

Comment 12

[Sajedul Islam]

As par comment 10 and comment 11, I am marking this bug as verified fixed.