1450999 - Browser Toolbox can't be resized

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Mark Banner (:standard8)]

I think as of today's nightly, the browser toolbox can't be resized. I'm pretty sure I was using it last night or this morning, and it was fine.

STR:

1) Start latest Firefox, either a self-build or a nightly
2) Open the browser Toolbox
3) Attempt to resize it.

=> Can't resize, the cursor never changes to <->

I'm on a Mac 10.13.4

Comment 1

[Brian Grinstead [:bgrins]]

I see the same on OSX in a local build at c44f60c43432

Comment 2

[Dave Townsend [:mossop]]

Mozregression says https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9d08798cee62592cd2fababcce404d3238eeb2b5&tochange=e4c46aab1b2f39349c5fcbb937136be7a9340da8

Comment 3

[Florian Quèze [:florian]]

Attachment: Patch

This patch reverts to the previous behavior. The old openWindow function from nsBrowserContent.js always provided 4 null arguments when opening a window. The C++ openWindow implementation behaves differently if the arg count is 0, at https://searchfox.org/mozilla-central/rev/f860c2bf00576959b07e2d9619c7b5088b0005be/toolkit/components/windowwatcher/nsWindowWatcher.cpp#326

The comment at https://searchfox.org/mozilla-central/rev/f860c2bf00576959b07e2d9619c7b5088b0005be/toolkit/components/windowwatcher/nsWindowWatcher.cpp#409-411 starting with "This is extremely messed up" makes me want to insert a hack to cowardly revert to the old behavior instead of trying to further disentangle how arguments are handled when opening windows.

Comment 4

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

Comment on attachment 8965335 [details] [diff] [review]
Patch

Review of attachment 8965335 [details] [diff] [review]:
-----------------------------------------------------------------

Ooof. :/ Thanks for finding and fixing this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed4586ca3284
always provide a null argument when opening a window for the -chrome command line parameter, otherwise the opened window is non-resizable, r=mconley.

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ed4586ca3284