1451011 - TRR: make blacklist duration 20 minutes by default

Status: RESOLVED FIXED

(Core :: Networking: DNS, enhancement, P1)

Description

[Daniel Stenberg [:bagder]]

The TRR blacklist's purpose is more to reduce immediate quick succession retries for names that won't work and it isn't really supposed to stick names in the "pit" for a long period of time.

The retry-with-native method is also working sufficiently good and transparent in most cases that the harm in expiring the name earlier from the blacklist is not that harsh on users.

But occasional glitches in the DOH server/network can get a name blacklisted and with this reduction, the impact of such a glitch is greatly reduced for the trr-first and race modes.

Comment 1

[Daniel Stenberg [:bagder]]

Attachment: bug 1451011 - expire TRR blacklist entries after 20 minutes by default

Review commit: https://reviewboard.mozilla.org/r/233318/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233318/

Comment 2

[Patrick McManus [:mcmanus]]

Comment on attachment 8964593 [details]
bug 1451011 - expire TRR blacklist entries after 20 minutes by default

https://reviewboard.mozilla.org/r/233318/#review238894

lgtm

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/087c9e29a3e0
expire TRR blacklist entries after 20 minutes by default r=mcmanus

Comment 4

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/087c9e29a3e0