Closed
Bug 1451038
Opened 6 years ago
Closed 6 years ago
Allow the ARM32 simulator to be compiled with clang
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: bbouvier, Assigned: bbouvier)
Details
Attachments
(1 file)
2.78 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8964603 -
Flags: review?(nfroyd)
Assignee | ||
Comment 1•6 years ago
|
||
Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1db64d70eb6e32c9bc202d6ea47333aeae384751
Comment 2•6 years ago
|
||
Comment on attachment 8964603 [details] [diff] [review] force-atomics.patch Review of attachment 8964603 [details] [diff] [review]: ----------------------------------------------------------------- r=me with the change below (assuming it builds, which it should). Thanks! ::: js/src/moz.build @@ +821,5 @@ > if CONFIG['CC_TYPE'] in ('clang', 'gcc'): > SOURCES['util/DoubleToString.cpp'].flags += ['-Wno-implicit-fallthrough'] > > +if CONFIG['MOZ_NEEDS_LIBATOMIC']: > + OS_LIBS += ['atomic'] On reflection, I think this belongs in js/src/build/moz.build.
Attachment #8964603 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 3•6 years ago
|
||
Yes, it works too, thanks!
Pushed by bbouvier@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/05669ce25b03 Make clang compile the JS ARM32 simulator shell; r=froydnj
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/05669ce25b03
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•