Closed Bug 1451038 Opened 6 years ago Closed 6 years ago

Allow the ARM32 simulator to be compiled with clang

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

Details

Attachments

(1 file)

      No description provided.
Attachment #8964603 - Flags: review?(nfroyd)
Comment on attachment 8964603 [details] [diff] [review]
force-atomics.patch

Review of attachment 8964603 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the change below (assuming it builds, which it should).  Thanks!

::: js/src/moz.build
@@ +821,5 @@
>  if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
>      SOURCES['util/DoubleToString.cpp'].flags += ['-Wno-implicit-fallthrough']
>  
> +if CONFIG['MOZ_NEEDS_LIBATOMIC']:
> +    OS_LIBS += ['atomic']

On reflection, I think this belongs in js/src/build/moz.build.
Attachment #8964603 - Flags: review?(nfroyd) → review+
Yes, it works too, thanks!
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05669ce25b03
Make clang compile the JS ARM32 simulator shell; r=froydnj
https://hg.mozilla.org/mozilla-central/rev/05669ce25b03
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: