1451174 - Use the new React 16.3+ StrictMode component

Status: NEW

(Tree Management :: Treeherder: Frontend, enhancement, P3)

Description

[Ed Morley [:emorley]]

See:
https://reactjs.org/blog/2018/03/29/react-v-16-3.html#strictmode-component
https://reactjs.org/docs/strict-mode.html

We presumably won't be able to use it everywhere, until we're leaning less on ngReact.

Comment 1

[Ed Morley [:emorley]]

I think we should do this soon, to ensure that any newly written React code adheres to best practices.

Comment 2

[Ed Morley [:emorley]]

Enabling this for job-view resulted in warnings coming from:
* react-hotkeys - I filed: https://github.com/greena13/react-hotkeys/issues/128
* react-tabs - existing issue: https://github.com/reactjs/react-tabs/issues/269
* reactstrap - existing issue: https://github.com/reactstrap/reactstrap/issues/1159
* react-transition-group - existing issue: https://github.com/reactjs/react-transition-group/issues/429
* react-select - existing issue: https://github.com/JedWatson/react-select/issues/3191
* react-input-autosize (used by react-select) - I filed: https://github.com/JedWatson/react-input-autosize/issues/147

For intermittent-failures:
* react-router - existing issue (and fixed on master): https://github.com/ReactTraining/react-router/issues/6060
* react-table - I filed: https://github.com/react-tools/react-table/issues/1193
* reactstrap (see above)
* react-transition-group (see above)

For test-view:
* react-redux - existing issue (and fixed on master): https://github.com/reduxjs/react-redux/issues/897
* react-router (see above)
* react-transition-group (see above)

I guess this is another reason we we should be very careful about adding too many dependencies - each one is another that can block us from having nice things.

Comment 3

[Ed Morley [:emorley]]

(In reply to Ed Morley [:emorley] from comment #2)
> * react-tabs - existing issue:
> https://github.com/reactjs/react-tabs/issues/269

This one is now fixed in react-tabs 3.0.0 (which Renovate will no doubt be opening a PR for shortly, once the unpublish timeout expires).