Closed
Bug 1451238
Opened 6 years ago
Closed 6 years ago
Port bug 1450279 to TB: Replace CAN_DRAW_IN_TITLEBAR with a run-time check
Categories
(Thunderbird :: Toolbars and Tabs, enhancement)
Thunderbird
Toolbars and Tabs
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 61.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(2 files)
12.07 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
8.68 KB,
patch
|
Details | Diff | Splinter Review |
Bug 1450279 removed the CAN_DRAW_IN_TITLEBAR variable. After this TB does no more draw in the titlebar.
Assignee | ||
Comment 1•6 years ago
|
||
With removing the CAN_DRAW_IN_TITLEBAR checks the draw in titlebar works again. Note: Actually the draw in titlebar doesn't work on TB start (Bug 1446151), You need a size change or a maximise/normalise to enable it.
Assignee | ||
Comment 2•6 years ago
|
||
msgMail3PaneWindow.js has a lot of white space change because of the removal of if{} conditions.
Comment 3•6 years ago
|
||
Comment on attachment 8964796 [details] [diff] [review] No-CAN_DRAW_IN_TITLEBAR.patch Works for me after a resize. Quite a fiddly port. What's happening in bug 1446151. There is a patch but no r? Bug 1439875 is also confusing. Landed, backed out, landed again, there appear to be follow-ups.
Attachment #8964796 -
Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/a02cd8ee7a96 Port bug 1450279 to TB: Replace CAN_DRAW_IN_TITLEBAR with a run-time check. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 61.0
Assignee | ||
Comment 5•6 years ago
|
||
(In reply to Jorg K (GMT+1) from comment #3) > > What's happening in bug 1446151. There is a patch but no r? Bug 1439875 is > also confusing. Landed, backed out, landed again, there appear to be > follow-ups. The patch doesn't fix the issue and I don't know how to initialise before the DOM content is shown like FX is doing. And then more important changes appeared in tree like overlays etc. Every help would be appreciated there.
Keywords: checkin-needed
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•