Remove resolved namespace id and tag from FCItems.

RESOLVED FIXED in Firefox 61

Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

unspecified
mozilla61
Points:
---

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

No description provided.
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8964798 [details]
Bug 1451239: Remove resolved namespace id and tag from FCItems.

https://reviewboard.mozilla.org/r/233526/#review239928

r=me

::: commit-message-96cea:7
(Diff revision 1)
> +
> +Tag is unused.
> +
> +This changes how some mixes of MathML and html get wrapped in anonymous table
> +boxes (in particular, it changes whether it uses a MathML or an HTML table
> +frame).

So the main thing this affects is whether the frame responds to certain attributes.

That said, responding to mathml attributes on its mContent when that mContent is not a MathML element seems ... weird.  So arguably the new setup is just more correct.  Might be worth it to explain that.

::: layout/base/nsCSSFrameConstructor.cpp:5530
(Diff revision 1)
>               "Unexpected display");
>  
>    static const FrameConstructionData sPageBreakData =
>      FCDATA_DECL(FCDATA_SKIP_FRAMESET, NS_NewPageBreakFrame);
>  
>    // Lie about the tag and namespace so we don't trigger anything

We're no longer lying about anything here.
Attachment #8964798 - Flags: review?(bzbarsky) → review+

Comment 3

a year ago
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9402bfb8bc8d
Remove resolved namespace id and tag from FCItems. r=bz

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9402bfb8bc8d
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.