1451246 - [mozrunner] Always encode key and value of env variables as UTF-8 if those are of unicode type

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Currently we only encode the key and value of env variables as UTF-8 if an interactive session is requested. But we also need that for non-interactive sessions given that `subprocess.Popen()` and specifically `os.execvpe()` would fail otherwise. For details see bug 1451062 comment 3.

https://dxr.mozilla.org/mozilla-central/rev/a1fb8ffae378963b128deaaf3a76eff9dbb6be21/testing/mozbase/mozrunner/mozrunner/base/runner.py#115-122

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1451246 - [mozrunner] Always encode key and value of env variables as UTF-8 if those are of unicode type.

Without encoding the key and value of environment variables as UTF-8
for non-interactive sessions "subprocess.Popen()" and specifically
"os.execvpe()" will fail.

Review commit: https://reviewboard.mozilla.org/r/233530/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233530/

Comment 2

[Geoff Brown [:gbrown]]

Comment on attachment 8964804 [details]
Bug 1451246 - [mozrunner] Always encode key and value of env variables as UTF-8 if those are of unicode type.

https://reviewboard.mozilla.org/r/233530/#review239282

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72c60d1c5461
[mozrunner] Always encode key and value of env variables as UTF-8 if those are of unicode type. r=gbrown

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/72c60d1c5461