1451251 - Add missing JS_INLINABLE_FN for some built-ins exposed to self-hosting code

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[André Bargull [:anba]]

JS_INLINABLE_FN is missing for:
- std_Array_join
- std_String_toLowerCase
- std_String_toUpperCase

Supporting these functions improve this µ-benchmark from 450ms to 360ms for me:
---
function f() {
    var q = 0;
    var t = dateNow();
    for (var i = 0; i < 1000000; ++i) {
        q += "".toLocaleLowerCase("de-de").length;
    }
    return [dateNow() - t, q];
}
---

And this one from 50ms to 30ms:
---
function f() {
    var q = 0;
    var t = dateNow();
    for (var i = 0; i < 1000000; ++i) {
        q += "".toLocaleLowerCase("de").length;
    }
    return [dateNow() - t, q];
}
---



JS_INLINABLE_FN should also be supported for:
- IsArrayBuffer
- IsSharedArrayBuffer

That will improve this µ-benchmark from 440ms to 390ms:
---
function f() {
    var ab = new ArrayBuffer(8);
    var q = 0;
    var t = dateNow();
    for (var i = 0; i < 1000000; ++i) {
        q += ab.slice(0).byteLength;
    }
    return [dateNow() - t, q];
}
---

And this one from 285ms to 135ms:
---
function f() {
    var ta = new Int32Array(16);
    ta.buffer; // IsSharedArrayBuffer is called if reified buffer is present.
    var q = 0;
    var t = dateNow();
    for (var i = 0; i < 5000000; ++i) {
        q += ta.fill(i)[0];
    }
    return [dateNow() - t, q];
}
---

Comment 1

[André Bargull [:anba]]

Attachment: bug1451251.patch

Adds inlining support for the built-ins mentioned in comment #0. Also removes the unused "IsReadableStreamBYOBRequest", "IsPromiseObject", and "CallPromiseMethodIfWrapped" exports.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8964805 [details] [diff] [review]
bug1451251.patch

Review of attachment 8964805 [details] [diff] [review]:
-----------------------------------------------------------------

Good finds!

Comment 3

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=be24138a88042e2a89b4a8d4b89ea04e0cf2c8ae

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab684911d520
Inline more functions used for self-hosting. r=jandem

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ab684911d520