1451334 - Can't use 0 as string maxLength nor array maxItems in schema

Status: RESOLVED WONTFIX

(WebExtensions :: General, defect)

Description

[Oriol Brufau [:Oriol]]

Attachment: test.xpi

You can define a schema with

    "choices": [
      {
        "type": "string",
        "maxLength": 0
      },
      {
        "type": "array",
        "items": {
          "type": "any"
        },
        "maxItems": 0
      }
    ]

but it will allow non-empty strings and non-empty arrays.

Enforcing a maximum of 0 seems stupid and I don't think Firefox schemas do it. But with the experiments API, authors can define their own schemas, and this bug becomes observable.

1. Open browser console
2. Install attached extension in about:debugging
In the console you should see 2 "TEST PASS - got an error"

Comment 1

[Shane Caraveo (:mixedpuppy)]

Unnecessary to have QA, it's covered by a test.

Comment 2

[Oriol Brufau [:Oriol]]

In bug 1448120 I only fixed "minimum" for integers. I didn't fix "maxLength" for strings nor "maxItems" for arrays.

Comment 3

[Oriol Brufau [:Oriol]]

Attachment: Bug 1451334 - Allow 0 as string maxLength or array maxItems in webextension schema

Review commit: https://reviewboard.mozilla.org/r/233692/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233692/

Comment 4

[Oriol Brufau [:Oriol]]

Why WONTFIX? This is obviously a bug. I can use maxLength:-1 and then "foo" throws, but if I use maxLength:0 then "foo" doesn't throw? That's nonsense.

Comment 5

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8964968 [details]
Bug 1451334 - Allow 0 as string maxLength or array maxItems in webextension schema

https://reviewboard.mozilla.org/r/233692/#review239384

zero for maxLength here doesn't seem reasonable.  throwing in other cases is not a big deal.