145134 - autocomplete list should not drop down when there are no matches and search engine line is not displayed

Status: RESOLVED DUPLICATE of bug 147870

(SeaMonkey :: Location Bar, defect)

Description

[:deanis74]

This is a specific case, but many of the annoyances of having the url bar
dropped down are described in bug 66834.

1. Enter junk in the url bar (eg. "zosdvodnuv")
2. Press tab to move to the content area, or click on a link

Expected Results: Things just work.

Actual Results: You try to figure out why you didn't tab to the document or the
link wasn't followed.  If you click again, the link is followed (bug 66834).  If
you press Tab again, the cursor still remains in the url bar.  When you squint
and look really close, you can see a small horizontal line below the url bar. 
After thinking for a couple of minutes, you realize that this is a zero-length
autocomplete list and press Esc to dismiss it.

This is because alwaysopenpopup is set to true in navigator.xul (see URL).  It
should be false.  Same goes for fastnav.xul, if that's kept up to date.

Comment 1

[:deanis74]

Attachment: simple patch to change this

Comment 2

[Joe Hewitt (gone)]

The point of the alwaysopenpopup attribute is because of the urlbar search
feature.  Even when there are no matches, it should show the line with the
search option.

Comment 3

[:deanis74]

The almost-invisible line that blocks clicks and tabs?  What's the point of that?

Comment 4

[Blake Ross]

Maybe you have the pref to show the search engine item off.

Comment 5

[Joe Hewitt (gone)]

If you're not seeing the line in the autocomplete popup that says "Search
<engine> for..." then that's a bug in itself.

Comment 6

[:deanis74]

Ahh yes.  Blake's right, I'm not showing the search engine item.  I confused the
"urlbar search feature" your previous comment with the list of autocomplete matches.

Resummarizing and re-opening.  This should not show only if the search engine
option is off and there are no matches.

Comment 7

[:deanis74]

Comment on attachment 89023 [details] [diff] [review]
simple patch to change this

Geez, that makes it more complicated.  This patch obviously won't do it.

Comment 8

[Itamar]

Hi,
it came to my attention that bug 147870 is related to this one.
I have attached a patch to that bug a long time ago but noticed that no one was
really intersted in fixing it so I just let it go.
I don't have a mozilla env' to test if the bug is still working but for going
over  it again I think it will.
Anyway - is any one still interasted in closing this bug?
If so can any one test the pach or post an updated one - since I won't be able
to update it in the coming weeks.

Comment 9

[:deanis74]

Yep, they're the same bug.

*** This bug has been marked as a duplicate of 147870 ***