1451405 - debug-only image observers run script during painting.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

Which breaks assertions we want to add.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Patch.

Notify off a script runner for this stuff.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8964984 [details] [diff] [review]
Patch.

>+  RefPtr<nsIURI> uri = mURI->ToIURI();

Why not nsCOMPtr?  Normally that's what we would use with an nsI* thing.

r=me with that fixed or explained.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c989bd874ddb726eb0d2c6390441d844e11098b2
https://hg.mozilla.org/mozilla-central/rev/c989bd874ddb

Comment 4

[Al Billings [:abillings - ex-MoCo]]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #3)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/
> c989bd874ddb726eb0d2c6390441d844e11098b2
> https://hg.mozilla.org/mozilla-central/rev/c989bd874ddb

How did this even get checked in without a sec-approval and a security rating?

Comment 5

[Al Billings [:abillings - ex-MoCo]]

Dan points out from the summary that this may be debug only? If so, I guess it made sense to check in. Emilio, can you confirm?

Comment 6

[Daniel Veditz [:dveditz]]

Not visible in the patch itself but this is in an "ifdef DEBUG" block and doesn't affect releases.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

It's debug only, yes.