Closed Bug 1451408 Opened 3 years ago Closed 3 years ago

Remove unused "button-repeat" binding

Categories

(Core :: XUL, task, P1)

Product:
Core
Component:
XUL
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: bgrins, Assigned: Paolo)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Bug 1451408 - Remove unused "button-repeat" binding.
59 bytes, text/x-review-board-request
bgrins
: review+
Details 
The only hit for type="repeat" I see is the binding attachment: https://searchfox.org/mozilla-central/search?q=type%3D%22repeat%22&case=false&regexp=false&path=. We should confirm it's unused and then remove the binding: https://searchfox.org/mozilla-central/source/toolkit/content/widgets/button.xml#375

Since button-repeat uses display="xul:autorepeatbutton" this will be a good one to unblock work in bug 1450652.
Keywords: good-first-bug
Taking since it blocks bug 1450652. The "autorepeatbutton" case is still in use for scrollbox, so the amount of code we can remove is limited.
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: -- → P1
Comment on attachment 8967396 [details]
Bug 1451408 - Remove unused "button-repeat" binding.

https://reviewboard.mozilla.org/r/236084/#review241830

LGTM with a green try
Attachment #8967396 - Flags: review?(bgrinstead) → review+
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d8757b2fc9e
Remove unused "button-repeat" binding. r=bgrins
https://hg.mozilla.org/mozilla-central/rev/4d8757b2fc9e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.