Closed
Bug 1451419
Opened 6 years ago
Closed 6 years ago
Topsites should have a #FFFFFF background fill on favicons with transparent backgrounds on Dark theme
Categories
(Firefox :: New Tab Page, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox61 | --- | verified |
People
(Reporter: amylee, Assigned: rrosario)
References
Details
Attachments
(2 files)
Topsites should have a #FFFFFF background fill on favicons with transparent backgrounds. See attachment.
Reporter | ||
Updated•6 years ago
|
Summary: Topsites should have a #FFFFFF background fill on favicons with transparent backgrounds → Topsites should have a #FFFFFF background fill on favicons with transparent backgrounds on Dark theme
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → rrosario
Assignee | ||
Updated•6 years ago
|
Iteration: --- → 61.2 - Apr 9
Assignee | ||
Updated•6 years ago
|
Priority: -- → P2
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/1d07b6188509323a80b500e2ee1f370fb1219723 Fix Bug 1451419 - set background of Top Site icons to $white https://github.com/mozilla/activity-stream/commit/22a5ed52915467d71acd184a86ceb3b707069efa Merge pull request #4081 from rlr/Bug1451419/favicon-background-color Fix Bug 1451419 - set background of Top Site icons to $white
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment 3•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3a5cfad58dd8
Target Milestone: --- → Firefox 61
Comment 4•6 years ago
|
||
Build ID 20180412001050 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0 The issue is no longer reproducible on the latest Nightly on Windows 10 x64, Mac 10.13.3 and Arch Linux. Top Sites have white backgrounds if their image background is transparent.
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•