Closed
Bug 1451426
Opened 6 years ago
Closed 6 years ago
add an iframe event listener leak test
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 3 obsolete files)
|
2.38 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
Continuation of bug 1450358.
|
Assignee | |
Comment 1•6 years ago
|
||
This tests a nested iframe for event listener leaks.
Attachment #8965006 -
Flags: review?(amarchesini)
|
|
Assignee | |
Comment 2•6 years ago
|
||
I forgot to hg add the test in the previous patch.
Attachment #8965006 -
Attachment is obsolete: true
Attachment #8965006 -
Flags: review?(amarchesini)
Attachment #8965036 -
Flags: review?(amarchesini)
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
|
Assignee | |
Comment 4•6 years ago
|
||
Comment on attachment 8965037 [details] [diff] [review] P2 Test that Notification does not leak via its event listeners. r=baku Andrea, this tests the Notification API for event listener leaks.
Attachment #8965037 -
Flags: review?(amarchesini)
|
||
Updated•6 years ago
|
Attachment #8965036 -
Flags: review?(amarchesini) → review+
|
|
||
Updated•6 years ago
|
Attachment #8965037 -
Flags: review?(amarchesini) → review+
|
|
Assignee | |
Comment 5•6 years ago
|
||
It appears the test triggers some NS_ASSERTION() stuff in Notification...
|
|
Assignee | |
Comment 6•6 years ago
|
||
Comment on attachment 8965037 [details] [diff] [review] P2 Test that Notification does not leak via its event listeners. r=baku Moved to bug 1451769.
Attachment #8965037 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•6 years ago
|
||
Let's just make this about testing iframe.
Summary: MOAR event listener leak tests → add an iframe event listener leak test
|
|
Assignee | |
Comment 8•6 years ago
|
||
Attachment #8965036 -
Attachment is obsolete: true
Attachment #8965356 -
Flags: review+
|
|
Assignee | |
Updated•6 years ago
|
Blocks: event-target-leaks
Pushed by bkelly@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/08fa7a65ad2f Test that iframe does not leak cotent windows through event listeners. r=baku
|
||
Comment 10•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/08fa7a65ad2f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•