1451474 - Colour updates needed on New Tab Search Bar Drop-Down Menu (Dark Theme)

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Amy Lee [:amylee] UX]

Attachment: New Tab Search Drop-Down Spec.png

Hi, 

Some of the colours in the New Tab search bar drop-down menu needs to be updated to match the search bar drop-down colours in the Chrome for Dark theme. 

See spec for reference. Thanks!

Comment 1

[Amy Lee [:amylee] UX]

Attachment: New Tab Search Drop-Down Spec.png

Comment 2

[Amy Lee [:amylee] UX]

Attachment: New Tab Search Drop-Down Spec.png

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4083

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/883134486f27e56cfe132dac80529236d163e92a
Fix Bug 1451474 - color updates for search drop down

https://github.com/mozilla/activity-stream/commit/5ba5d58f6b722295da3e20ca207246f124cb2508
Merge pull request #4083 from rlr/Bug1451474/search-dropdown-style-fixes

Fix Bug 1451474 - color updates for search drop down

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/3a5cfad58dd8

Comment 6

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Build ID 	20180412001050
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

The issue is no longer reproducible on the latest Nightly on Windows 10 x64, Mac 10.13.3 and Arch Linux. The New Tab Search Bar colors now match the Address Bar colors on dark theme.