Closed Bug 1451475 Opened 2 years ago Closed 2 years ago

Renew scalar browser.engagement.restored_pinned_tabs_count

Categories

(Firefox :: Tabbed Browser, enhancement, P1)

49 Branch
enhancement

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: chutten, Assigned: janerik)

Details

Attachments

(2 files, 1 obsolete file)

browser.engagement.restored_pinned_tabs_count is about to expire. Its information may become useful within the next five releases, so we should renew it.

This is subject to Data Collection Review: https://wiki.mozilla.org/Firefox/Data_Collection
Assignee: chutten → jrediger
MozReview-Commit-ID: 7Lbdu5IHSE
Attachment #8966982 - Flags: review?(chutten)
Attachment #8966983 - Flags: review?(chutten)
Comment on attachment 8966982 [details] [diff] [review]
Renew scalar browser.engagement.restored_pinned_tabs_count.

Review of attachment 8966982 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/Scalars.yaml
@@ +944,5 @@
>  devtools.responsive:
>    toolbox_opened_first:
>      bug_numbers:
>        - 1444497
> +      - 1451475

This... doesn't seem right?
Attachment #8966982 - Flags: review?(chutten)
DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? (see here, here, and here for examples).

Yes, per Telemetry norms.

    Is there a control mechanism that allows the user to turn the data collection on and off? 

Yes, the Telemetry checkbox.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2

    Is the data collection request for default-on or default-off?

Default-on

    Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

    Is the data collection covered by the existing Firefox privacy notice? 

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :janerik, could you file a bug for this please?

---
Result: datareview+ pending bug for renewal decision targeting 67.
Flags: needinfo?(jrediger)
Attachment #8966983 - Flags: review?(chutten) → review+
Woops, that should obviously have gone into the right scalar description.

MozReview-Commit-ID: 7Lbdu5IHSE
Attachment #8967301 - Flags: review?(chutten)
Attachment #8966982 - Attachment is obsolete: true
Flags: needinfo?(jrediger)
Attachment #8967301 - Flags: review?(chutten) → review+
Keywords: checkin-needed
Pushed by aiakab@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cdffc974d116
Renew scalar browser.engagement.restored_pinned_tabs_count r=chutten
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cdffc974d116
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.