Closed
Bug 1451487
Opened 6 years ago
Closed 6 years ago
Remove isAddonBlocklisted API from nsIBlocklistService
Categories
(Toolkit :: Blocklist Policy Requests, enhancement)
Toolkit
Blocklist Policy Requests
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
Attachments
(1 file)
It seems this API was the original way of checking if an add-on was in the blocklist. Then we ended up with different blocklist states ("soft block"), in bug 455906 (1.9.1!), which needed a more finegrained result out of the blocklist. At that point there were still a few consumers of the old API (and of course we had xpcom add-ons to think of). By Fx4 / mozilla2.0, only 3 non-test consumers were left. All 3 were for update-related addon compat checks. They were removed in bug 1262880 (Firefox 49). AFAICT rather than making an async equivalent, we can just nuke this API from orbit.
Assignee | ||
Comment 1•6 years ago
|
||
Link for mozilla2.0 results: https://dxr.mozilla.org/mozilla2.0/search?q=isaddonblocklisted
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•6 years ago
|
||
I'll probably need to rebase after the renames in bug 1449255, but that shouldn't overly influence the review/patch here.
Assignee | ||
Comment 4•6 years ago
|
||
(In reply to :Gijs (he/him) from comment #3) > I'll probably need to rebase after the renames in bug 1449255, but that > shouldn't overly influence the review/patch here. Rebased patch incoming.
Comment hidden (mozreview-request) |
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8965255 [details] Bug 1451487 - remove nsIBlocklistService::isAddonBlocklisted as it's unused, https://reviewboard.mozilla.org/r/233972/#review239736
Attachment #8965255 -
Flags: review?(dtownsend) → review+
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4b5ca5e0be5c remove nsIBlocklistService::isAddonBlocklisted as it's unused, r=mossop
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4b5ca5e0be5c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•