Closed Bug 1451489 Opened 7 years ago Closed 7 years ago

Context menu does not display correctly when viewing source of a message

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird60 fixed, thunderbird61 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 61.0
Tracking Flags:
Tracking Status
thunderbird60 --- fixed
thunderbird61 --- fixed

People

(Reporter: travis, Assigned: Paenglab)

References

Details

Attachments

(2 files)

Screenshot_2018-04-04_13-54-23.png
103.86 KB, image/png
Details
viewSource.patch
2.09 KB, patch
jorgk-bmo
: review+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0 Build ID: 20180327185825 Steps to reproduce: When viewing the source of a message, the context menu does not appear correctly. This is when using version Thunderbird 60.0b1 (64-bit) on Linux Mint 18.3 and Xfce 4.12. Also occurs under Safe Mode. Actual results: A menu appeared showing separators but the labels for "Find Again", "Copy", and "Select All" does not appear. Clicking where the options should be does not do anything. Expected results: The context menu should appear and function.
I see this too.
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attached patch viewSource.patch — — Splinter Review
Some context menus didn't became expanded with labels etc. on port to c-c.
Attachment #8965417 - Flags: review?(jorgk)
Attachment #8965417 - Flags: approval-comm-beta?
Does "view source" work at all on trunk, I get JavaScript error: chrome://messenger/content/viewSource.js, line 277: TypeError: wrapMenuItem is null
Comment on attachment 8965417 [details] [diff] [review] viewSource.patch Thanks, that restores the context menu.
Attachment #8965417 - Flags: review?(jorgk)
Attachment #8965417 - Flags: review+
Attachment #8965417 - Flags: approval-comm-beta?
Attachment #8965417 - Flags: approval-comm-beta+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/d2597729f2d8 Add missing context menuitem labels and commands. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 61.0
Component: Untriaged → Mail Window Front End
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: