1451492 - Wording of Treeherder view for brand-new Try push is still sometimes the unfriendly version

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect)

Description

[Botond Ballo [:botond]]

Attachment: Screenshot of Treeherder message

I just pushed some patches to Try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=574eddb0d54d1ba69fd7d779f57ff19543375d96\

and opened the Treeherder link printed by the mercurial command.

The Treeherder message displayed on that page was "This repository is either unknown to Treeherder or it does not exist" (see attached screenshot).

I would expect the displayed message to be the "Waiting for a push with revision" message; my understanding is this was fixed in bug 1440862.

Comment 1

[Botond Ballo [:botond]]

Just happened again with https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f79f2c6ffde79695956d8b15bc4becdae25715b

Comment 2

[Cameron Dawson [:camd]]

I'll take a look.

Comment 3

[Botond Ballo [:botond]]

And again with https://treeherder.mozilla.org/#/jobs?repo=try&revision=32e6b671a8c3df0928b5ae4edd0c75808fd8de45.

(I'm just posting additional links in case they are useful as additional data points for investigation.)

Comment 4

[Botond Ballo [:botond]]

One more data point: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=6047ab9ac46a891c430f42dbeedc4555123172bb

Comment 5

[Cameron Dawson [:camd]]

I'm having a hard time reproducing this.  It gives them "Waiting for a push..." message for me.  But I'm wondering if it's a race condition where our query for the names of the repos has not yet returned and so we punt to the unfriendly message.  If reloading the page once or twice fixes it, that could be what's happening.  

Taking a deeper look at the code to safeguard this now...

Comment 6

[Cameron Dawson [:camd]]

I was able to reproduce this locally.  I have a solution in a PR for bug 1408791.  It will fix this as well.  No, really this time...

Comment 7

[Cameron Dawson [:camd]]

Fixed by:

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/4f2ee0c88b89b5fa9dcf0059308c4316d1df6e7c
Bug 1408791 - Move to using react2angular (#3462)

Comment 8

[Botond Ballo [:botond]]

Started seeing this again today. Example push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b8bebe8e27b28a884192ba8c8eba9aceffe28dc9

Comment 9

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #8)
> Started seeing this again today. Example push:
> 
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=b8bebe8e27b28a884192ba8c8eba9aceffe28dc9

And in recent days I see it every time I open a Try link after pushing.

Comment 10

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4079

Comment 11

[Cameron Dawson [:camd]]

I broke this with the ``SelectedJob`` context PR.  I should have fetched the revision from the URL at that point.  This new PR does that.

Comment 12

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/0bab0205f2d833f6e345af607a13f006d248ed7f
Bug 1451492 - Fix wording awaiting a new revision (#4079)