Closed Bug 1451492 Opened 3 years ago Closed 3 years ago

Wording of Treeherder view for brand-new Try push is still sometimes the unfriendly version

Categories

(Tree Management :: Treeherder: Frontend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: botond, Assigned: camd)

References

Details

Attachments

(2 files)

I just pushed some patches to Try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=574eddb0d54d1ba69fd7d779f57ff19543375d96\

and opened the Treeherder link printed by the mercurial command.

The Treeherder message displayed on that page was "This repository is either unknown to Treeherder or it does not exist" (see attached screenshot).

I would expect the displayed message to be the "Waiting for a push with revision" message; my understanding is this was fixed in bug 1440862.
I'll take a look.
Assignee: nobody → cdawson
And again with https://treeherder.mozilla.org/#/jobs?repo=try&revision=32e6b671a8c3df0928b5ae4edd0c75808fd8de45.

(I'm just posting additional links in case they are useful as additional data points for investigation.)
I'm having a hard time reproducing this.  It gives them "Waiting for a push..." message for me.  But I'm wondering if it's a race condition where our query for the names of the repos has not yet returned and so we punt to the unfriendly message.  If reloading the page once or twice fixes it, that could be what's happening.  

Taking a deeper look at the code to safeguard this now...
I was able to reproduce this locally.  I have a solution in a PR for bug 1408791.  It will fix this as well.  No, really this time...
Depends on: 1408791
Fixed by:

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/4f2ee0c88b89b5fa9dcf0059308c4316d1df6e7c
Bug 1408791 - Move to using react2angular (#3462)
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
(In reply to Botond Ballo [:botond] from comment #8)
> Started seeing this again today. Example push:
> 
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=b8bebe8e27b28a884192ba8c8eba9aceffe28dc9

And in recent days I see it every time I open a Try link after pushing.
Flags: needinfo?(cdawson)
I broke this with the ``SelectedJob`` context PR.  I should have fetched the revision from the URL at that point.  This new PR does that.
Flags: needinfo?(cdawson)
Attachment #9012936 - Flags: review?(sclements)
Attachment #9012936 - Flags: review?(sclements) → review+
You need to log in before you can comment on or make changes to this bug.