1451503 - Convert reftest extension from bootstrap to a webextension

Status: RESOLVED FIXED

(Testing :: Reftest, enhancement)

Description

[Andrew Swan [:aswan]]

Depending on how much enthusiasm whoever ends up doing this has, some things could be modernized a bit or we could just do a quick-and-dirty conversion of the existing code to a WebExtension experiment.

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1451503 Allow addonStartup.registerChrome() to register contentaccesible content packages

Comment 2

[Andrew Swan [:aswan]]

Attachment: Bug 1451503 Move most reftest resources from chrome: to resource:

This can be squashed together with the next patch for landing but is
separated here for simpler reviewing.

Comment 3

[Andrew Swan [:aswan]]

Attachment: Bug 1451503 Convert reftest to a webextension

Comment 4

[Andrew Swan [:aswan]]

:dbaron, I'm about to flag you for review on a couple of patches here since you're listed as the author of the reftest extension.  If you don't work on reftest any more, aren't interested in the details of the webextension conversion, or just don't have the bandwidth to review, please let me know and I'll find another reviewer.

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 9007116 [details]
Bug 1451503 Allow addonStartup.registerChrome() to register contentaccesible content packages

Kris Maglione [:kmag] has approved the revision.

Comment 6

[Kris Maglione [:kmag]]

Comment on attachment 9007118 [details]
Bug 1451503 Convert reftest to a webextension

Kris Maglione [:kmag] has approved the revision.

Comment 7

[Andrew Halberstadt [:ahal]]

(In reply to Andrew Swan [:aswan] from comment #2)
> This can be squashed together with the next patch for landing but is
> separated here for simpler reviewing.

As long as they can both land alone without failures, might as well keep them separate. Smaller commits make it easier to find regressions/run blame.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to Andrew Swan [:aswan] from comment #4)
> :dbaron, I'm about to flag you for review on a couple of patches here since
> you're listed as the author of the reftest extension.  If you don't work on
> reftest any more, aren't interested in the details of the webextension
> conversion, or just don't have the bandwidth to review, please let me know
> and I'll find another reviewer.

I think it's better to find another reviewer for this one; this is the part of reftest that's been converted from one thing to another multiple times since I've written it...

Comment 9

[Andrew Swan [:aswan]]

Will do, thanks for the reply.  As soon as I sort out the Android failures :/

Comment 10

[Kris Maglione [:kmag]]

Comment on attachment 9007117 [details]
Bug 1451503 Move most reftest resources from chrome: to resource:

Kris Maglione [:kmag] has approved the revision.

Comment 11

[Andrew Swan [:aswan]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4453b0554c92e1d898ec223b54450399357ddb7e
Bug 1451503 Allow addonStartup.registerChrome() to register contentaccesible content packages r=kmag

https://hg.mozilla.org/integration/mozilla-inbound/rev/b656d0cc250eb290a3cb188042cf111ff281eac2
Bug 1451503 Move most reftest resources from chrome: to resource: r=kmag

https://hg.mozilla.org/integration/mozilla-inbound/rev/1858dfdbd0e36d382e03354bd728f81be58a3fc3
Bug 1451503 Convert reftest to a webextension r=kmag

Comment 12

[Andrew Swan [:aswan]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d90650b21b19504814458f7de791f526804f60ec

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4453b0554c92
https://hg.mozilla.org/mozilla-central/rev/b656d0cc250e
https://hg.mozilla.org/mozilla-central/rev/1858dfdbd0e3