Closed Bug 1451593 Opened Last year Closed Last year

[wpt-sync] Sync PR 10325 - Remove stylesheet of link element when rel != stylesheet

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10325 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10325
Details from upstream follow.

Rakina Zata Amni <rakina@chromium.org> wrote:
>  Remove stylesheet of link element when rel != stylesheet
>  
>  Stylesheets from link elements that previously have rel = "stylesheet"
>  but then changed to something else should be removed/not considered
>  anymore until the rel attribute is changed back to "stylesheet" again.
>  
>  Currently this works correctly for link elements in the document tree,
>  but fails in link elements within a shadow tree because link elements
>  in shadow tree with rel attribute != "stylesheet"  are skipped from
>  processing. Because of that, the stylesheet in the link element was
>  never cleared and no style recalc happened.
>  JSBin from bug: http://jsbin.com/bojunajaju/edit?html,console,output
>  
>  
>  Bug:817355
>  Change-Id: I57c71c79c0cc471d36eb988b8a81eef82c33548a
>  Reviewed-on: https://chromium-review.googlesource.com/995116
>  WPT-Export-Revision: f468a841ee33f9163634237b33b70483db2e2c8d
Component: web-platform-tests → DOM
Product: Testing → Core
Ran 1 tests and 2 subtests
OK     : 1
PASS   : 1
FAIL   : 1

New tests that have failures or other problems:
/shadow-dom/link-rel-attribute.html
    Removing stylesheet from link rel attribute should remove the stylesheet for shadow DOM: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/78401ceeed7c
[wpt PR 10325] - Remove stylesheet of link element when rel != stylesheet, a=testonly
https://hg.mozilla.org/mozilla-central/rev/78401ceeed7c
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.