Closed Bug 1451627 Opened 2 years ago Closed 2 years ago

Crash in java.lang.NullPointerException: at org.mozilla.geckoview.BasicSelectionActionDelegate.performAction(BasicSelectionActionDelegate.java)

Categories

(GeckoView :: General, defect, P1, critical)

Unspecified
Android
defect

Tracking

(firefox-esr52 unaffected, firefox59 unaffected, firefox60 unaffected, firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox-esr52 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- fixed

People

(Reporter: calixte, Assigned: jchen)

References

(Blocks 1 open bug)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is
report bp-d984bb60-e556-495b-b5dc-b5baf0180404.
=============================================================

java.lang.NullPointerException: Attempt to invoke interface method 'void org.mozilla.geckoview.GeckoSession$Response.respond(java.lang.Object)' on a null object reference
	at org.mozilla.geckoview.BasicSelectionActionDelegate.performAction(BasicSelectionActionDelegate.java:136)
	at org.mozilla.geckoview.BasicSelectionActionDelegate.onActionItemClicked(BasicSelectionActionDelegate.java:186)
	at org.mozilla.geckoview.BasicSelectionActionDelegate$Callback2Wrapper.onActionItemClicked(BasicSelectionActionDelegate.java:59)
	at com.android.internal.policy.DecorView$ActionModeCallback2Wrapper.onActionItemClicked(DecorView.java:2256)
	at com.android.internal.view.FloatingActionMode$3.onMenuItemSelected(FloatingActionMode.java:87)
	at com.android.internal.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:761)
	at com.android.internal.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:152)
	at com.android.internal.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:904)
	at com.android.internal.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:894)
	at com.android.internal.view.FloatingActionMode$4.onMenuItemClick(FloatingActionMode.java:113)
	at com.android.internal.widget.FloatingToolbar$FloatingToolbarPopup$3.onClick(FloatingToolbar.java:394)
	at android.view.View.performClick(View.java:5609)
	at android.view.View$PerformClick.run(View.java:22263)
	at android.os.Handler.handleCallback(Handler.java:751)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:154)
	at android.app.ActivityThread.main(ActivityThread.java:6077)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:865)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:755)

=============================================================

There are 2 crashes (from 2 installations) in nightly 61 with buildid 20180403100100. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1441279.

[1] https://hg.mozilla.org/mozilla-central/rev?node=cf58dd36b5e4
Flags: needinfo?(nchen)
Assignee: nobody → nchen
Priority: -- → P1
Flags: needinfo?(nchen)
Comment on attachment 8965504 [details]
Bug 1451627 - Don't use SelectionActionDelegate in Fennec;

https://reviewboard.mozilla.org/r/234290/#review240560
Attachment #8965504 - Flags: review?(esawin) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8141ec5c350f
Don't use SelectionActionDelegate in Fennec; r=esawin
https://hg.mozilla.org/mozilla-central/rev/8141ec5c350f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox for Android → GeckoView
Keywords: crash, regression
Target Milestone: Firefox 61 → mozilla61
You need to log in before you can comment on or make changes to this bug.