Closed Bug 1451665 Opened 6 years ago Closed 6 years ago

Tools list should be updated every time a new tool is registered/unregistered.

Categories

(DevTools :: Framework, defect)

61 Branch
x86_64
Windows 10
defect
Not set
normal

Tracking

(firefox61 verified)

VERIFIED FIXED
Firefox 61
Tracking Status
firefox61 --- verified

People

(Reporter: tbabos, Assigned: yzen)

References

Details

Attachments

(2 files)

Attached video Video of the issue
[Affected versions]:
Latest Nightly 61.0a1 Build ID: 20180404224504, try build from 2018-03-27

[Affected Platforms]:
Windows 10 x64

[Prerequisites]:
- Install an open Firefox

[Steps to reproduce]:
1.Web console and toolbox options is opened on at least 3 different tabs
2 Open the inspector and go to settings
3. Add the “Accessibility” feature to the Dev Tools panel for each tab (mark the Accessibility checkbox under the Default developer Tools section)
4. Repeat the above step for all 3 opened tabs
5. Click on one of the “Accessibility” tabs.
6. Remove the mentioned feature from the Dev Tools panel starting from the last opened tab

[Expected result]:
The Web Console should properly sync the added/removed Developer Tools for each opened tab.

[Actual result]:
3. The “Accessibility” feature can be added once again in the Dev Tools panel for each opened tab or new window
5. If one of the mentioned tab is clicked on, all the Accessibility tabs will be focused
6. The web console does not update correctly when the Accessibility is removed from the Dev Tools panel via Toolbox Options, thus the checkbox afferent for Accessibility will be checked even if the feature is not in the Dev Tools panel anymore.
For more information, please check the attached file.

[Note]:
This issue is also reproducible for all the features that are not by default selected in the Default Developer Tools.
This is not really a11y panel bug but I'll take it. This happens with any tool on the list, e.g. DOM panel, or the ones that are already enabled. We currently only update the list when web extensions are registered/unregistered.
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Summary: The Web Console does not update the Toolbox Options selected for the Dev Tool panel on multiple tabs → Tools list should be updated every time a new tool is registered/unregistered.
Component: Developer Tools: Accessibility Tools → Developer Tools: Framework
Attached patch 1451665 patchSplinter Review
Attachment #8967445 - Flags: review?(jryans)
Comment on attachment 8967445 [details] [diff] [review]
1451665 patch

Review of attachment 8967445 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, looks reasonable to me! :)
Attachment #8967445 - Flags: review?(jryans) → review+
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a12783364ce6
update tool list every time tool is registered/unregistered. r=jryans
Backed out for devtools failures on browser_toolbox_options.js

backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/538106142cb2198442edecd824257e87be8f0eed

push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=a12783364ce6c79a6b3e8b258382088e995b116d&selectedJob=173418983

failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=173420333&repo=mozilla-inbound&lineNumber=11414

21:17:55     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options.js | There should be a toggle checkbox for: webaudioeditor - 
21:17:55     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options.js | There should be a toggle checkbox for: scratchpad - 
21:17:55     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options.js | There should be a toggle checkbox for: dom - 
21:17:55     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options.js | There should be a toggle checkbox for: accessibility - 
21:17:55     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options.js | There should be a toggle checkbox for: test-tool - 
21:17:55     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options.js | Correct tool removed - 
21:17:55     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options.js | Tab removed for styleeditor - 
21:17:55     INFO - Buffered messages finished
21:17:55     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_toolbox_options.js | Test timed out - 
21:17:55     INFO - GECKO(1911) | ++DOMWINDOW == 16 (0x120178400) [pid = 1911] [serial = 283] [outer = 0x11fd6dc00]
21:17:55     INFO - Removing tab.
21:17:55     INFO - Waiting for event: 'TabClose' on [object XULElement].
21:17:55     INFO - Got event: 'TabClose' on [object XULElement].
21:17:55     INFO - Tab removed and finished closing
21:17:55     INFO - GECKO(1911) | MEMORY STAT | vsize 4530MB | residentFast 618MB | heapAllocated 100MB
21:17:55     INFO - TEST-OK | devtools/client/framework/test/browser_toolbox_options.js | took 90516ms
Flags: needinfo?(yzenevich)
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/69f26860c7d2
update tool list every time tool is registered/unregistered. r=jryans
https://hg.mozilla.org/mozilla-central/rev/69f26860c7d2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Verified fixed using latest Nightly 61.0a1 (2018-04-18) on Windows 10 x64, Windows 7 x64, Ubuntu 16.04 x64 and Mac OS X 10.12.
Status: RESOLVED → VERIFIED
removing old ni?
Flags: needinfo?(yzenevich)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.