Closed Bug 1451685 Opened 2 years ago Closed 2 years ago

TypeError: element.setAttribute is not a function

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: Gijs, Assigned: zbraniecki)

References

()

Details

(Whiteboard: [nightly-js-sentry:3493204])

Attachments

(1 file)

This bug was automatically filed from Sentry: https://sentry.prod.mozaws.net/operations/nightly-js-errors/issues/3493204/

TypeError: element.setAttribute is not a function
    at setAttributes(resource://gre/modules/DOMLocalization.jsm:433:5)
    at updateWeavePrefs/<(chrome://browser/content/preferences/in-content/sync.js:292:7)
    at forEach(self-hosted:268:13)
    at updateWeavePrefs(chrome://browser/content/preferences/in-content/sync.js:290:5)
    at _init(chrome://browser/content/preferences/in-content/sync.js:162:5)
    at init(chrome://browser/content/preferences/in-content/sync.js:59:7)
    at init(chrome://browser/content/preferences/in-content/preferences.js:43:7)
    at init_category_if_required(chrome://browser/content/preferences/in-content/preferences.js:36:3)
    at gotoPref(chrome://browser/content/preferences/in-content/preferences.js:159:5)
    at onHashChange(chrome://browser/content/preferences/in-content/preferences.js:112:3)

Looks like this is a result of the fluent conversion. Unsure if this is related to the specific conversion or the DOMLocalization code itself. :gandalf, can you take a look?
Flags: needinfo?(gandalf)
Definitely on me. Taking!
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Comment on attachment 8965279 [details]
Bug 1451685 - Pass element as the first argument to DOMLocalization.setAttributes in updateWeavePrefs.

https://reviewboard.mozilla.org/r/234012/#review239618
Attachment #8965279 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7382668f782a
Pass element as the first argument to DOMLocalization.setAttributes in updateWeavePrefs. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/7382668f782a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Flags: needinfo?(gandalf)
You need to log in before you can comment on or make changes to this bug.