1451709 - Remove code for the "Restore Tabs From Last Time" button in the tab bar

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task)

Description

[Dão Gottwald [:dao]]

The shield study is long finished (bug 1400942) and the design has flaws that we're supposed to be addressed in the next iteration (bug 1219725 comment 143). It doesn't look like that iteration is going to happen anytime soon, but if needed this code can be brought back. No point in keeping shipping it in its current form.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0cfacd81b178d5894fbe3cabfc75d14a606821a

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1451709 - Remove code for the "Restore Tabs From Last Time" button in the tab bar.

Review commit: https://reviewboard.mozilla.org/r/234028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234028/

Comment 2

[Erica Wright [:ewright]]

We are still waiting on the data for this, though we are expecting it soon. Should we remove the code before this?

Comment 3

[Dão Gottwald [:dao]]

(In reply to Erica Wright [:ewright] from comment #2)
> We are still waiting on the data for this, though we are expecting it soon.
> Should we remove the code before this?

This can happen independently as I understand it. At this point you're processing the data rather than gathering it (let alone in Nightly), right?

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8965290 [details]
Bug 1451709 - Remove code for the "Restore Tabs From Last Time" button in the tab bar.

https://reviewboard.mozilla.org/r/234028/#review240080

I understand the reasoning behind the removal, Dão, but having this block the 'war-on-xbl' bug is stretching it a bit, don't you think? I mean, sure this removes some code from the tabbrowser binding, but not a complete binding at all.
Hence I'm not sure whether this is a high priority issue to tackle.

Can you ask Blake whether the probes are OK to remove at this point?

Comment 5

[Dão Gottwald [:dao]]

(In reply to Mike de Boer [:mikedeboer] (Back! Processing backlog...) from comment #4)
> Comment on attachment 8965290 [details]
> Bug 1451709 - Remove code for the "Restore Tabs From Last Time" button in
> the tab bar.
> 
> https://reviewboard.mozilla.org/r/234028/#review240080
> 
> I understand the reasoning behind the removal, Dão, but having this block
> the 'war-on-xbl' bug is stretching it a bit, don't you think? I mean, sure
> this removes some code from the tabbrowser binding, but not a complete
> binding at all.

Both number of bindings and XBL LOC are being tracked. This wasn't my primary motivation though. I'm also interested in not having to worry about this e.g. in bug 1033225 and related efforts since the tab strip layout is already tricky enough. Generally it's just not a great idea to keep and ship pref'd off code indefinitely.

> Can you ask Blake whether the probes are OK to remove at this point?

Blake, is anything still depending on the ability to send these probes in Nightly? (Not talking about potential future uses, as the probes can be resurrected if needed.)

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Given that the shield study is done, and that the feature might be broken by some upcoming fixes, I believe we're okay to remove the code and the probes. Thanks for asking!

Comment 7

[Mike de Boer [:mikedeboer]]

(In reply to Dão Gottwald [::dao] from comment #5)
> Both number of bindings and XBL LOC are being tracked. This wasn't my
> primary motivation though. I'm also interested in not having to worry about
> this e.g. in bug 1033225 and related efforts since the tab strip layout is
> already tricky enough. Generally it's just not a great idea to keep and ship
> pref'd off code indefinitely.

I'm totally on board with this!

(In reply to Blake Winton (:bwinton) (:☕️) from comment #6)
> Given that the shield study is done, and that the feature might be broken by
> some upcoming fixes, I believe we're okay to remove the code and the probes.
> Thanks for asking!

Alright, let's (un)ship it!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63eaada61b96
Remove code for the "Restore Tabs From Last Time" button in the tab bar. r=mikedeboer

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/63eaada61b96