Closed Bug 1451725 Opened 2 years ago Closed 2 years ago

Remove deprecated WebDriver commands

Categories

(Testing :: Marionette, enhancement, P3)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: whimboo, Assigned: vpit3833)

References

Details

(Whiteboard: [has to wait for firefox 63])

Attachments

(1 file)

As noted in the code we should remove all the deprecated commands for Firefox 60, so we don't have to carry those along with the ESR release:

https://dxr.mozilla.org/mozilla-central/rev/c23c7481957f7b982cffc0ce1d25979c69ca2c2f/testing/marionette/driver.js#3587-3653

A little bit more work seems to be necessary for setWindowPosition and setWindowSize (bug 1348145) which a contributor starts working on now. I would leave that as a separate bug.
Doh! We cannot get them all removed because Marionette client doesn't support the new commands yet. So the client has to be updated and released first. Given the still a bit unclear status of the update tests, we need further releases before we can remove all old commands from driver.js. :(

I will file a new client bug, to get all the commands updated.
Depends on: 1451727
Depends on: 1452024
Priority: -- → P3
With bug 451727 fixed and uplifted soon for Firefox 60, the removal of the old commands has to wait until Firefox 63.
Whiteboard: [has to wait for firefox 63]
Attachment #8995762 - Flags: review?(hskupin)
Comment on attachment 8995762 [details]
Bug 1451725 - Remove deprecated WebDriver Commands

https://reviewboard.mozilla.org/r/260128/#review267754

Thank you! The try build also passes, so that I will try to get it landed now.
Attachment #8995762 - Flags: review?(hskupin) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea17a96c5eb0
Remove deprecated WebDriver Commands r=whimboo
https://hg.mozilla.org/mozilla-central/rev/ea17a96c5eb0
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Assignee: nobody → venkateshpitta
You need to log in before you can comment on or make changes to this bug.