Closed Bug 1451780 Opened 2 years ago Closed 2 years ago

Fix selction actions for password fields

Categories

(GeckoView :: General, enhancement, P1)

All
Android
enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(1 file)

Right now we show "cut" and "copy" for password fields but shouldn't.
Comment on attachment 8965503 [details]
Bug 1451780 - Add password field detection for selection actions;

https://reviewboard.mozilla.org/r/234286/#review240558

::: mobile/android/chrome/geckoview/GeckoViewSelectionActionContent.js:183
(Diff revision 1)
>        const msg = {
>          type: "GeckoView:ShowSelectionAction",
>          seqNo: this._seqNo,
>          collapsed: aEvent.collapsed,
>          editable: aEvent.selectionEditable,
> -        selection: aEvent.selectedTextContent,
> +        password: password,

password,
Attachment #8965503 - Flags: review?(esawin) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f4e7771b85c
Add password field detection for selection actions; r=esawin
https://hg.mozilla.org/mozilla-central/rev/3f4e7771b85c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 61 → mozilla61
You need to log in before you can comment on or make changes to this bug.