Closed Bug 1451781 Opened 2 years ago Closed 2 years ago
Follow up correction on disable Opus phase inversion fix
Bug 1451781 - Check if output device is mono and remove stereo check in order to disable opus channel inversion.
59 bytes, text/x-review-board-request
On Bug 1431810 channel inversion of opus decoder is disabled when audio output is mono. This patch take cares two follow up comments on the landed fix. Comment 1 is described in that comment . Comment 2 is from jmspeex (on IRC) who suggested that I do not need to check that the Opus file itself is stereo because Opus files can switch from mono to stereo (and back) without warning. Disabling inversion does nothing for mono anyway.  https://bugzilla.mozilla.org/show_bug.cgi?id=1431810#c35
Assignee: nobody → achronop
Priority: -- → P2
Comment on attachment 8965364 [details] Bug 1451781 - Check if output device is mono and remove stereo check in order to disable opus channel inversion. https://reviewboard.mozilla.org/r/234086/#review240508 ::: dom/media/VideoUtils.cpp:30 (Diff revision 1) > #include "nsIRandomGenerator.h" > #include "nsIServiceManager.h" > #include "nsMathUtils.h" > #include "nsServiceManagerUtils.h" > #include "nsThreadUtils.h" > +#include "CubebUtils.h" alphabetical order.
Attachment #8965364 - Flags: review?(jyavenard) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/8fc7e04ebbf4 Check if output device is mono and remove stereo check in order to disable opus channel inversion. r=jya
You need to log in before you can comment on or make changes to this bug.