1451781 - Follow up correction on disable Opus phase inversion fix

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Alex Chronopoulos [:achronop]]

On Bug 1431810 channel inversion of opus decoder is disabled when audio output is mono. This patch take cares two follow up comments on the landed fix.

Comment 1 is described in that comment [1].
Comment 2 is from jmspeex (on IRC) who suggested that I do not need to check that the Opus file itself is stereo because Opus files can switch from mono to stereo (and back) without warning. Disabling inversion does nothing for mono anyway.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1431810#c35

Comment 1

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1451781 - Check if output device is mono and remove stereo check in order to disable opus channel inversion.

Review commit: https://reviewboard.mozilla.org/r/234086/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234086/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8965364 [details]
Bug 1451781 - Check if output device is mono and remove stereo check in order to disable opus channel inversion.

https://reviewboard.mozilla.org/r/234086/#review240508

::: dom/media/VideoUtils.cpp:30
(Diff revision 1)
>  #include "nsIRandomGenerator.h"
>  #include "nsIServiceManager.h"
>  #include "nsMathUtils.h"
>  #include "nsServiceManagerUtils.h"
>  #include "nsThreadUtils.h"
> +#include "CubebUtils.h"

alphabetical order.

Comment 3

[Alex Chronopoulos [:achronop]]

Comment on attachment 8965364 [details]
Bug 1451781 - Check if output device is mono and remove stereo check in order to disable opus channel inversion.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/234086/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fc7e04ebbf4
Check if output device is mono and remove stereo check in order to disable opus channel inversion. r=jya

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/8fc7e04ebbf4